Skip to content

[pigeon] Adds writeHeaders method to Generator classes and updates tests to use new Generators. #3000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 57 commits into from
Closed

[pigeon] Adds writeHeaders method to Generator classes and updates tests to use new Generators. #3000

wants to merge 57 commits into from

Conversation

tarrinneal
Copy link
Contributor

@tarrinneal tarrinneal commented Dec 22, 2022 •
edited
Loading

Adds writeHeaders method to Generator classes and updates tests to use new Generators.

work towards flutter/flutter#117416

Waiting for #2996 to merge

@tarrinneal
Rename generator class to Adapter
df851d5
@tarrinneal
create new generator class and dart subclass
e40d679
@tarrinneal
cpp and dart test gen
8c4e2a0
@tarrinneal
added files
bcdbdbc
@tarrinneal
Adds Generator class to all generators
31bb701
@tarrinneal
adds swift
06315ce
@tarrinneal
Updates tests to use new Adapter naming scheme
5675c64
@tarrinneal
Dart generate methods
a319b48
@tarrinneal
convert all generate functions to use new method
6d7405d
@tarrinneal
Merge branch 'main' of github.com:flutter/packages into skeleton2
72a380c
@tarrinneal
chagngelog
1e59fef
@tarrinneal
remove Generator class fields
0964cd3
@tarrinneal
move paths to options
f589da4
@tarrinneal
remove dartTestOptions
637679d
@tarrinneal
Moves write header to generator class method
af5e0e6
@tarrinneal
Updates tests to use new generator class
ae817ad
@tarrinneal
source -> header
5cecc21
@tarrinneal
correct options
99f25b5
@tarrinneal
header -> source
16df207
@tarrinneal
header -> prefix, source -> header
049c6be
@tarrinneal
remove headers from generateTestDart
a2dcb1c
@tarrinneal
changelog
e4c78f5
@tarrinneal
Copy link
Contributor Author

I'll clean up these commits once #2996 is merged

@tarrinneal
cleaner header methods
6856812
@tarrinneal
Fixes dart header bug
6206bad
@tarrinneal
Merge branch 'skeleton2' into skelington3
f17c0a3
@tarrinneal
add gen files for clarity
7c3d35c
@tarrinneal
Merge branch 'main' of github.com:flutter/packages into skeleton2
ef0b71a
@tarrinneal
better field naming
8bf2dfb
@tarrinneal
better field naming
8c6abf2
@tarrinneal
removed unneeded dart test generator
93a5d1b
@tarrinneal
Add filetype to generator
710d1a1
@tarrinneal
Adds filetype as field to generatorAdapters
d189d11
@tarrinneal
Merge branch 'skeleton2' into skelington3
8e068fa
@tarrinneal
merge
859c6cb
@tarrinneal
Merge branch 'main' of github.com:flutter/packages into skeleton2
daae569
@tarrinneal
Merge branch 'main' of github.com:flutter/packages into skelington3
f23b5b6
@tarrinneal
analyze
6dff8cb
@tarrinneal
re-remove DartTestGenerator
d9f116f
@tarrinneal
Merge branch 'main' of github.com:flutter/packages into skeleton2
88905e3
@tarrinneal
nits
29decb9
@tarrinneal
assert
b7abbe4
@tarrinneal
Merge branch 'skeleton2' into skelington3
00ea54b
@tarrinneal tarrinneal mentioned this pull request Jan 3, 2023
Closed
@tarrinneal
Copy link
Contributor Author

replaced with #3029

@tarrinneal tarrinneal closed this Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaaclarke gaaclarke Awaiting requested review from gaaclarke

@stuartmorgan-g stuartmorgan-g Awaiting requested review from stuartmorgan-g

Assignees
No one assigned
Labels
p: pigeon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tarrinneal