Skip to content

Conversation

bparrishMines
Copy link
Contributor

@bparrishMines bparrishMines commented Dec 8, 2022

BuildContext.dependOnInheritedElement has been removed, so this breaks the implementation of BuildContext. Since the class isn't used anyway, this just deletes it.

Analyzing go_router...
  error - test/test_helpers.dart:227:19 - 'DummyBuildContext.dependOnInheritedElement' ('InheritedWidget Function(InheritedElement, {Object aspect})') isn't a valid override of 'BuildContext.dependOnInheritedElement' ('InheritedWidget Function(InheritedElement, {Object? aspect})'). - invalid_override
           - The member being overridden at test/test_helpers.dart:336:86770.

Fix to roller failure in #2914

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@bparrishMines bparrishMines changed the title remove context and flutter version bump [ci][go_router] Bumps Flutter master version and removes unused BuildContext implementation Dec 8, 2022
Copy link
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bparrishMines bparrishMines added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 8, 2022
@auto-submit auto-submit bot merged commit 717331c into flutter:main Dec 8, 2022
@bparrishMines bparrishMines deleted the remove_context branch December 8, 2022 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: go_router

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants