Skip to content

Use correct path to typed routing library #2381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Use correct path to typed routing library #2381

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/go_router_builder/lib/src/go_router_generator.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ class GoRouterGenerator extends GeneratorForAnnotation<void> {

@override
TypeChecker get typeChecker => const TypeChecker.fromUrl(
'package:go_router/src/route_data.dart#TypedGoRoute',
'package:go_router/src/typed_routing.dart#TypedGoRoute',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevmoo Do you know if we change this to package:go_router/go_router.dart#TypedGoRoute instead? go_router.dart exports this library.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't seem to work...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note also that changing go_router_builder can't be a complete fix for the issue created by 4.2.1; a complete fix must be in go_router.

Versions of go_router_builder that have this src dependency have already been published and are in use in the wild, and they depend on go_router: ^4.0.0. People using those existing versions can get new versions of go_router without getting new versions of go_router_builder, so unless you are comfortable breaking those people by violating semver you need to revert or otherwise fix go_router before publishing it again as 4.x.x.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typedgoroute is exposed as a public class, this should be 'package:go_router/go_router.dart#TypedGoRoute`

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this doesn't seem to work

);

@override
Expand Down Expand Up @@ -82,5 +82,5 @@ ${getters.map((String e) => "$e,").join('\n')}
}

const TypeChecker _goRouteDataChecker = TypeChecker.fromUrl(
'package:go_router/src/route_data.dart#GoRouteData',
'package:go_router/src/typed_routing.dart#GoRouteData',
);