-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[go_router] Refactor internal classes and methods #2317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
370a279
Refactor internal classes and methods
johnpryan aaec44a
format
johnpryan 61fbc2d
Sort imports
johnpryan 632b012
Update changelog
johnpryan 40e2c61
Address code review comments
johnpryan 61da05d
remove routing library
johnpryan 1c2577c
Move classes in go_router.dart into separate libraries
johnpryan db91f56
Move Configuration.validate() into constructor
johnpryan 1eaf6c3
Remove comment
johnpryan ea01665
use continue in redirect loop
johnpryan d4c2ff9
Fix comments
johnpryan 199c353
Sort imports
johnpryan b8a65af
Fix logging in configuration
johnpryan 85fe41d
add visibleForTesting annotation
johnpryan ccb8097
Merge branch 'main' into refactor
johnpryan e0bb4f4
Updates from merge with main
johnpryan 4c17bba
Format
johnpryan 8449014
Add TODOs to make Router implementation classes private
johnpryan 9b40f1e
Add copyright headers
johnpryan 0e14a04
Fix tests
johnpryan 73feaa8
Merge branch 'main' into refactor
johnpryan e3458e6
format
johnpryan 13bc273
fix comment
johnpryan 2a350ad
Update packages/go_router/lib/src/parser.dart
johnpryan fc82dbb
add whitespace
johnpryan 86c8961
format
johnpryan 7f8954c
Hide typedefs that weren't previously exported
johnpryan fdcf0ed
Delete empty file
johnpryan 78e60a6
add missing import
johnpryan 26b4c12
Specify version 4.1.2 in pubspec.yaml
johnpryan 0c5436e
Update packages/go_router/lib/src/builder.dart
johnpryan 348697b
Fix comment
johnpryan 77f2244
Add isError and error getters to RouteMatchList
johnpryan 820162d
Add issue links to TODO comments
johnpryan 07f7ada
Add link to issue for TODO
johnpryan 686d315
Merge branch 'main' into refactor
johnpryan 5e282d3
Re-apply code from #2306 due to merge conflicts
johnpryan 714e682
Add issue references
johnpryan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
# Miscellaneous | ||
*.class | ||
*.log | ||
*.pyc | ||
*.swp | ||
.DS_Store | ||
.atom/ | ||
.buildlog/ | ||
.history | ||
.svn/ | ||
migrate_working_dir/ | ||
|
||
# IntelliJ related | ||
*.iml | ||
*.ipr | ||
*.iws | ||
.idea/ | ||
|
||
# The .vscode folder contains launch configuration and tasks you configure in | ||
# VS Code which you may wish to be included in version control, so this line | ||
# is commented out by default. | ||
#.vscode/ | ||
|
||
# Flutter/Dart/Pub related | ||
# Libraries should not include pubspec.lock, per https://dart.dev/guides/libraries/private-files#pubspeclock. | ||
/pubspec.lock | ||
**/doc/api/ | ||
.dart_tool/ | ||
.packages | ||
build/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.