[canvaskit] add text style goldens #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferhatb
approved these changes
Jan 20, 2021
Contributor
ferhatb
left a comment
ferhatb
left a comment
There was a problem hiding this comment.
Can you please double check locale_zh, seems wrong
Contributor
Author
This is expected. I'm landing a PR that fixes 2 issues, but my test is capturing as many text scenarios as possible. Some of these screenshots actually contain issues for unfixed issues. In the test I'm leaving links to the relevant issues and other PRs (flutter/engine#23800). As we fix those issues we'll just update the goldens at the same time. |
yjbanov
force-pushed
the
ck-text-style-goldens
branch
from
26327b1 to
19345d1
Compare
yjbanov
force-pushed
the
ck-text-style-goldens
branch
from
19345d1 to
38262d4
Compare
Contributor
Author
|
I regenerated the screenshots after merging with @hterkelsen's Noto changes. You will see that CJK goldens have improved. There's still an issue with spaces. I filed github issues for all bugs that I spotted. PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.