Skip to content

Conversation

@nturgut
Copy link
Contributor

@nturgut nturgut commented Sep 14, 2020

PR is adding capability to take ios-screenshots. These will be used as goldens.

@nturgut nturgut requested review from mdebbar and yjbanov September 14, 2020 16:00
@yjbanov
Copy link
Contributor

yjbanov commented Sep 14, 2020

I see a couple of issues:

@nturgut
Copy link
Contributor Author

nturgut commented Sep 14, 2020

I see a couple of issues:

I don't see any horizontal line, can you send me a screenshot or a name or something I can use?
https://raw.githubusercontent.com/flutter/goldens/master/engine/web/backdrop_filter_clip.png
https://raw.githubusercontent.com/flutter/goldens/master/engine/web/draw_vertices_triangle_fan.png

@nturgut
Copy link
Contributor Author

nturgut commented Sep 15, 2020

I see a couple of issues:

I adjust the scaling as we discussed offline. I also removed the header from the images that have them. PHAL

Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nturgut
Copy link
Contributor Author

nturgut commented Sep 15, 2020

Thanks for the review!

@nturgut nturgut merged commit 29f96fb into flutter:master Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants