This repository was archived by the owner on Jun 13, 2024. It is now read-only.
Enable external view embedder on iOS to test benchmark #267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After rolling flutter/engine#19919 into the framework, we enabled dynamic thread merging on iOS. Which means enabling the external view embedder will still keep raster thread and platform thread separate until there are platform views on the scene.
Which then means the performance should be relatively unchanged just by enabling the external view embedder on gallery.
This PR enables the external view embedder on iOS so we can watch for the benchmark.