Skip to content

Conversation

@gspencergoog
Copy link
Contributor

@gspencergoog gspencergoog commented Jan 12, 2022

Description

This extracts the examples that are in https://github.com/flutter/engine/blob/main/lib/ui/text.dart into examples in the examples/api/lib/ui directory and adds some simple tests for them.

Also, fixes some inconsistent test file naming.

This is step 1: the next step is to remove the examples from the dart:ui code.

Tests

  • Added tests for each of the extracted samples.

@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation f: material design flutter/packages/flutter/material repository. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Jan 12, 2022
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More LGTM

@gspencergoog gspencergoog merged commit 017ed17 into flutter:master Jan 14, 2022
@gspencergoog gspencergoog deleted the dart_ui_examples branch January 14, 2022 23:42
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 4, 2022
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
…96557)

This extracts the examples that are in flutter/engine@main/lib/ui/text.dart into examples in the examples/api/lib/ui directory and adds some simple tests for them.

Also, fixes some inconsistent test file naming.

This is step 1: the next step is to remove the examples from the dart:ui code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: text input Entering text in a text field or keyboard related problems c: contributor-productivity Team-specific productivity, code health, technical debt. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: material design flutter/packages/flutter/material repository.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants