Add system channel to access the localization plugin. #76847
Conversation
flutter-dashboard
bot
added
the
framework
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
| /// specified, the current system locale is used instead. | ||
| static const MethodChannel localization = OptionalMethodChannel( | ||
| 'flutter/localization', | ||
| JSONMethodCodec(), |
There was a problem hiding this comment.
Passing on opinion of a reviewer I had on platform channels:
We should avoid unnecessary use of JSON codec if possible. If the contents can be passed with StandardMethodCodec, we prefer that over the extra layer of JSON parsing.
There was a problem hiding this comment.
Discussed offline. This is actually an existing channel that uses JSON codec already.
GaryQian
left a comment
GaryQian
left a comment
There was a problem hiding this comment.
LGTM with caveat of reviewing the codec.
2 participants
Framework side declaration for go/flutter-locale-split.