Skip to content

Conversation

abrush21
Copy link
Contributor

@abrush21 abrush21 commented Sep 14, 2020

Description

This change adds get and set methods for the new semantics slider flag.

Related Issues

https://github.com/abrush21/flutter/pull/new/slider-flag-2

Tests

I added the following tests:

Extended existing tests to include slider flag.

Checklist

Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

@flutter-dashboard flutter-dashboard bot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) framework flutter/packages/flutter repository. See also f: labels. work in progress; do not review labels Sep 14, 2020
@abrush21
Copy link
Contributor Author

Checks expected to fail until flutter/engine#20385 lands.

@abrush21 abrush21 marked this pull request as ready for review September 14, 2020 21:56
@goderbauer
Copy link
Member

Looks like the engine change has rolled into flutter. Can you rebase this onto the latest master to see if tests pass now? Thanks.

@chunhtai
Copy link
Contributor

Hi @abrush21 , Do you what is the current status of this PR?

Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunhtai chunhtai merged commit d693d2b into flutter:master Sep 29, 2020
apomalyn added a commit to apomalyn/flutter that referenced this pull request Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants