Skip to content

Conversation

@hpoul
Copy link
Contributor

@hpoul hpoul commented Aug 27, 2020

Description

There is an inconsistency between the migration guide for pre flutter 1.12 android applications: https://github.com/flutter/flutter/wiki/Upgrading-pre-1.12-Android-projects and the current app templates.

According to the guide (for both, Full-Flutter app migration as well as for Add-to-app migration):

  1. Remove the reference to FlutterApplication from the application tag.

This PR removes FlutterApplication from AndroidManifest.xml to make it consistent with manually upgraded projects.

Related Issues

  • No issue which would be fixed

Tests

No tests, as this does not add any functionality.

Checklist

Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read [Handling breaking changes].

  • No, no existing tests failed, so this is not a breaking change.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Aug 27, 2020
@zanderso zanderso requested review from blasten and xster September 3, 2020 20:42
@xster
Copy link
Member

xster commented Sep 3, 2020

Reminds me I need to merge flutter/engine#20769 (since this inadvertently hides a problem flutter/engine#20769 fixes) . Let's merge this after our next branch cut next week.

Copy link
Member

@xster xster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. flutter/engine#20769 is merged as well.

Please wait until Sept 14th before merging this.

@jonahwilliams
Copy link
Contributor

@xster September 14th of this year, right? :)

@xster
Copy link
Member

xster commented Sep 17, 2020

Thanks for reminding Jonah! Merge on green.

@fluttergithubbot fluttergithubbot merged commit af21434 into flutter:master Sep 17, 2020
goderbauer pushed a commit to goderbauer/flutter that referenced this pull request Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants