Skip to content

Conversation

HansMuller
Copy link
Contributor

@HansMuller HansMuller commented Oct 3, 2016

Added basic support for the scale input gesture to the Gallery grid demo.

Added a flingVelocity parameter to the scaleEnd() callback.

Copy link
Contributor

@abarth abarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

_focalPoint = _flingAnimation.value;
_lastFocalPoint = _focalPoint;
});

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra blank line.


/// Signature for when the pointers are no longer in contact with the screen.
typedef void GestureScaleEndCallback();
typedef void GestureScaleEndCallback(Velocity flingVelocity);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if these should take details objects. That's the pattern we've adopted for the other gestures.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. I can take a stab at that in a separate PR.

@HansMuller HansMuller merged commit 596637a into flutter:master Oct 3, 2016
@HansMuller HansMuller deleted the grid_demo_zoom branch October 3, 2016 23:08
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants