Remove the "most valuable keys" Hero feature #5500
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @Hixie |
| key: new ObjectKey(stock), | ||
| tag: stock, | ||
| turns: 2, | ||
| child: new StockArrow(percentChange: stock.percentChange) |
There was a problem hiding this comment.
since you're passing in the stock anyway, why not do this in the StockSymbolView builder?
|
This patch is beautiful. LGTM. |
This was referenced Aug 19, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heroes are now identified exclusively by their object-valued tag.
Fixes #5403