Improve how ImageIcon does opacity #4847
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| Widget result = new Image( | ||
| if (iconOpacity != null && iconOpacity != 1.0) | ||
| iconColor = iconColor.withOpacity(iconOpacity); |
There was a problem hiding this comment.
Should this be iconColor.withOpacity(iconOpacity * iconColor.opacity) ?
There was a problem hiding this comment.
Yeah, that's probably a good idea.
|
LGTM |
Putting the opacity in the color is much faster than using an opacity widget because the opacity widget creates an offscreen buffer. Fixes flutter#4651
abarth
force-pushed
the
improve_icon_opacity
branch
from
0922124 to
9e44ceb
Compare
cdotstout
pushed a commit
to cdotstout/flutter
that referenced
this pull request
Apr 3, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Putting the opacity in the color is much faster than using an opacity
widget because the opacity widget creates an offscreen buffer.
Fixes #4651