Revised Drawer Header #4160
Merged
Revised Drawer Header #4160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
|
gspencergoog
added a commit
that referenced
this pull request
Oct 2, 2017
* Add framework-side support for system text scale factor. * Rolling engine to e3404b8 Additional changes rolled in with engine change: libtxt: implementation of GetRectsForRange that processes a line at a time - e3404b8 Provide an entropy source to the Dart engine (#4161) - e1aa867 libtxt: search for fallback fonts that can match emoji and CJK characters - 8061df1 Roll skia to e4679fa06a. (#4157) - 267e7a8 Update buildroot to 53fea9a (#4160) - 02ea7ae Revert engine Dart roll. (#4158) - 14aab33 Add support for system text scale factor. (#4124) - b2a7f4b Include _http into sky_engine libraries for analyzer (#4154) - b930f10 libtxt: Remove postprocess_line and improve tracking of X offsets - 86f95f0 libtxt: remove redundant line_widths (#4152) - 14bf515 Roll dart to ade37f931e90b0fdb8fe16d6bf6f089545da55b6 (#4151) - 6f1264f
cdotstout
pushed a commit
to cdotstout/flutter
that referenced
this pull request
Apr 3, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DrawerHeader now has two widgets: background and content. The background extends behind the status bar and the content appears below the status bar and on top of the background. The content is effectively inset by 16 pixels on all sides and there's a divider at the bottom of the header (as before).
This is an incompatible change. To restore an existing DrawerHeader to exactly the way it was: