Skip to content

Conversation

@arbreng
Copy link
Contributor

@arbreng arbreng commented Apr 13, 2019

Description

Fuchsia doesn't use view_manager anymore, so remove this from the CMX template

Related Issues

N/A

Tests

N/A, no behavior change

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@goderbauer goderbauer added customer: fuchsia customer: gallery Relating to flutter/gallery repository. Please transfer non-framework issues there. platform-fuchsia Fuchsia code specifically labels Apr 15, 2019
@arbreng arbreng requested a review from zanderso April 15, 2019 23:13
@arbreng arbreng merged commit 4dd1525 into flutter:master Apr 16, 2019
Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

For Flutter PRs the practice is to wait for an lgtm before merging.

@arbreng
Copy link
Contributor Author

arbreng commented Apr 16, 2019

Thanks for the review; I'msorry about that! The change seemed so safe that I figured I could just merge it this time.

@arbreng arbreng deleted the remove-view-manager branch April 16, 2019 16:58
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

customer: fuchsia customer: gallery Relating to flutter/gallery repository. Please transfer non-framework issues there. platform-fuchsia Fuchsia code specifically

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants