Skip to content

Add support for running dart2wasm in dry run mode on js compilations #171682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 8, 2025
Merged

Add support for running dart2wasm in dry run mode on js compilations #171682

merged 8 commits into from
Jul 8, 2025
+116 −33

Conversation

biggs0125
Copy link
Contributor

Example message with findings:


Wasm dry run findings:
Found incompatibilities with WebAssembly.

package:counter1/main.dart 3:1 - dart:html unsupported (0)


Consider addressing these issues to enable wasm builds. See docs for more info: https://docs.flutter.dev/platform-integration/web/wasm


Compiling lib/main.dart for the Web...                             10.9s
✓ Built build/web

Example message without findings:


Wasm dry run succeeded. Consider building and testing your application with the `--wasm` flag. See docs for more info: https://docs.flutter.dev/platform-integration/web/wasm

Compiling lib/main.dart for the Web...                             10.8s
✓ Built build/web

@biggs0125 biggs0125 requested review from kevmoo and mdebbar July 7, 2025 02:40
@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jul 7, 2025
mdebbar
mdebbar requested changes Jul 8, 2025
View reviewed changes
@biggs0125 biggs0125 requested a review from mdebbar July 8, 2025 18:03
mdebbar
mdebbar approved these changes Jul 8, 2025
View reviewed changes
Copy link
Contributor

@mdebbar mdebbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@biggs0125 biggs0125 added this pull request to the merge queue Jul 8, 2025
Merged via the queue into flutter:master with commit b5b3636 Jul 8, 2025
137 checks passed
@biggs0125 biggs0125 deleted the wasm-dry-run branch July 8, 2025 22:15
@mdebbar mdebbar mentioned this pull request Jul 9, 2025
Merged
@ash2moon ash2moon mentioned this pull request Jul 9, 2025
Draft
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 9, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 9, 2025
@engine-flutter-autoroll
b5b363610 Add support for running dart2wasm in dry run mode on js com…
882202b 
…pilations (flutter/flutter#171682)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 9, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 9, 2025
@engine-flutter-autoroll
b5b363610 Add support for running dart2wasm in dry run mode on js com…
8fbeb80 
…pilations (flutter/flutter#171682)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 9, 2025
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 9, 2025
@engine-flutter-autoroll
b5b363610 Add support for running dart2wasm in dry run mode on js com…
f207f86 
…pilations (flutter/flutter#171682)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jul 9, 2025
@engine-flutter-autoroll
Roll Flutter from adffe244f3f1 to ac12f66681f1 (28 revisions) (#9584)
421e77c 
flutter/flutter@adffe24...ac12f66

2025-07-09 [email protected] Roll Packages from cba2e90 to 4a231ae (5 revisions) (flutter/flutter#171879)
2025-07-09 [email protected] Replace [FinderBase] with [Finder] in the documentation of Matchers (flutter/flutter#168279)
2025-07-09 [email protected] Revert "Mark web_long_running_tests_2_5 as bringup" (flutter/flutter#171872)
2025-07-09 [email protected] Apply normalization to TimePickerThemeData.inputDecorationTheme (flutter/flutter#171584)
2025-07-09 [email protected] Fix InputDecorationThemeData.activeIndicatorBorder is not applied (flutter/flutter#171764)
2025-07-09 [email protected] Fix multi-view GL rendering not working since software rendering was added (flutter/flutter#171409)
2025-07-09 [email protected] Marks Linux_android_emu android_engine_vulkan_tests to be unflaky (flutter/flutter#171141)
2025-07-08 [email protected] Roll Fuchsia Linux SDK from AinHuT0vgOelA1g7_... to 0-xqmXWc4cXzw3tfe... (flutter/flutter#171823)
2025-07-08 [email protected] Marks Linux_android_emu android_display_cutout to be unflaky (flutter/flutter#171140)
2025-07-08 [email protected] [Documentation] When updating kgp minimum document additional changes that are required (flutter/flutter#171819)
2025-07-08 [email protected] Marks Linux_android_emu android_engine_opengles_tests to be unflaky (flutter/flutter#171142)
2025-07-08 [email protected] Add support for running dart2wasm in dry run mode on js compilations (flutter/flutter#171682)
2025-07-08 [email protected] Remove now duplicate un-forward ports for Android (flutter/flutter#171473)
2025-07-08 [email protected] [skia] Update usage of removed gn flag (flutter/flutter#171800)
2025-07-08 [email protected] [web] Disable auto-formatting for the stack_trace.dart test file (flutter/flutter#171801)
2025-07-08 [email protected] Bump warn and error versions of agp, kotlin and gradle versions in preparation for gradle 9 (flutter/flutter#171776)
2025-07-08 [email protected] Removed string keys (flutter/flutter#171293)
2025-07-08 [email protected] Add `radioSide` to `RadioListTile` (flutter/flutter#171318)
2025-07-08 [email protected] Roll Fuchsia Test Scripts from ZpnML-jis0gVIvtx5... to MnFlN7VWM_7h7EmBV... (flutter/flutter#171787)
2025-07-08 [email protected] Add/use `addMachineOutputFlag`/`outputsMachineFormat` instead of strings (flutter/flutter#171459)
2025-07-08 [email protected] Update translation from console (flutter/flutter#171556)
2025-07-08 [email protected] [ Tool ] Support upgrading to a new Flutter version pointing to the same revision as a previous version (flutter/flutter#171783)
2025-07-08 [email protected] Multi-window support (engine) (flutter/flutter#168728)
2025-07-08 [email protected] Fixes an issue where TapRegion would consume taps regardless of navigation state (flutter/flutter#169067)
2025-07-08 [email protected] SliverSemantics (flutter/flutter#167300)
2025-07-08 [email protected] Roll Skia from e159882c6ce0 to 0fef076beec3 (3 revisions) (flutter/flutter#171779)
2025-07-08 [email protected] Run hot_restart_web_amd_test.dart on Mac/Windows (flutter/flutter#171281)
2025-07-08 [email protected] Roll Packages from 2c52f24 to cba2e90 (2 revisions) (flutter/flutter#171775)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mboetger pushed a commit to mboetger/flutter that referenced this pull request Jul 9, 2025
@biggs0125 @natebiggs @mboetger
Add support for running dart2wasm in dry run mode on js compilations (f…
d3580be 
…lutter#171682)

Example message with findings:

```

Wasm dry run findings:
Found incompatibilities with WebAssembly.

package:counter1/main.dart 3:1 - dart:html unsupported (0)


Consider addressing these issues to enable wasm builds. See docs for more info: https://docs.flutter.dev/platform-integration/web/wasm


Compiling lib/main.dart for the Web...                             10.9s
✓ Built build/web
```

Example message without findings:

```

Wasm dry run succeeded. Consider building and testing your application with the `--wasm` flag. See docs for more info: https://docs.flutter.dev/platform-integration/web/wasm

Compiling lib/main.dart for the Web...                             10.8s
✓ Built build/web
```

---------

Co-authored-by: Nate Biggs <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Jul 9, 2025
@biggs0125 @natebiggs
Add analytics events for wasm dry runs on web builds (#171818)
06ce4bb 
Follow up to #171682
Depends on dart-lang/tools#2125

---------

Co-authored-by: Nate Biggs <[email protected]>
azatech pushed a commit to azatech/flutter that referenced this pull request Jul 10, 2025
@biggs0125 @natebiggs @azatech
Add analytics events for wasm dry runs on web builds (flutter#171818)
8077bb5 
Follow up to flutter#171682
Depends on dart-lang/tools#2125

---------

Co-authored-by: Nate Biggs <[email protected]>
mboetger pushed a commit to mboetger/flutter that referenced this pull request Jul 21, 2025
@biggs0125 @natebiggs @mboetger
Add support for running dart2wasm in dry run mode on js compilations (f…
18ace2d 
…lutter#171682)

Example message with findings:

```

Wasm dry run findings:
Found incompatibilities with WebAssembly.

package:counter1/main.dart 3:1 - dart:html unsupported (0)


Consider addressing these issues to enable wasm builds. See docs for more info: https://docs.flutter.dev/platform-integration/web/wasm


Compiling lib/main.dart for the Web...                             10.9s
✓ Built build/web
```

Example message without findings:

```

Wasm dry run succeeded. Consider building and testing your application with the `--wasm` flag. See docs for more info: https://docs.flutter.dev/platform-integration/web/wasm

Compiling lib/main.dart for the Web...                             10.8s
✓ Built build/web
```

---------

Co-authored-by: Nate Biggs <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdebbar mdebbar mdebbar approved these changes

@kevmoo kevmoo Awaiting requested review from kevmoo

Assignees
No one assigned
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@biggs0125 @mdebbar @natebiggs