explicitly set packageConfigPath for strategy providers

[jyameo]

• Explicitly set packageConfigPath for strategy providers
• update DWDS version to 24.3.5

fixes #161469

[flutter-dashboard]

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

[srujzs]

Awesome! I'd like to land a test somewhere for this so we don't break it in the future accidentally, but it's hard to tell what to test for. The aforementioned bug mentions error logs (which I guess we could test for, but that feels like a brittle/bad test) and breakpoint issues. I wonder if we could create a test in DWDS to check whether breakpoints in a synthesized monorepo are working as intended. There are also some tests in this repo that test different package_config.json but it requires a bit more investigation.

Anyways, LGTM and we can maybe think of a test separately.

[srujzs]

FYI - I believe the way to autosubmit is to use the label autosubmit and not use the merge queue directly (I accidentally did the same last week as well :)). It looks like google3 testing never completed when this landed, but iirc, there's a separate issue there due to an infra failure, so this PR passed all the necessary checks anyways.

[jyameo]

FYI - I believe the way to autosubmit is to use the label autosubmit and not use the merge queue directly (I accidentally did the same last week as well :)). It looks like google3 testing never completed when this landed, but iirc, there's a separate issue there due to an infra failure, so this PR passed all the necessary checks anyways.

Ah! I see. Thanks for the info. I'll keep that in mind next time :)

[mikebosland]

Thanks for the fix! Any estimate in what release / timeline this will land in? Debugging web in workspaces continues to be broken, making life a little harder. :)

[srujzs]

This is in the most recent Flutter 3.31 beta. Stable release should be roughly 3 months after the last one, so this should be in a stable sometime in May.

[mikebosland]

Thank you for the timeline info.

I personally find it difficult without a working debugger. I suppose I can switch to the beta. I suppose there have been insufficient complaints to warrant a cherry pick?

[srujzs]

Yeah I haven't seen enough traffic, but I also believe it would be a complicated cherry-pick since it relies on a new version of DWDS, which potentially could bring in multiple other issues.