Skip to content

[Impeller] fix scaling of trampoline import of GLES textures into Vulkan. #161331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 9, 2025
Merged

[Impeller] fix scaling of trampoline import of GLES textures into Vulkan. #161331

merged 5 commits into from
Jan 9, 2025

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Jan 8, 2025 •
edited
Loading

Not sure if this just needs the dpr transform or the entire canvas transform.

Fixes #159688

Before

flutter_04

After

flutter_03

@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems platform-android Android applications specifically engine flutter/engine related. See also e: labels. labels Jan 8, 2025
@jonahwilliams jonahwilliams changed the title [Wip][Impeller] fix scaling of trampoline import. [Impeller] fix scaling of trampoline import of GLES textures into Vulkan. Jan 9, 2025
@jonahwilliams jonahwilliams marked this pull request as ready for review January 9, 2025 00:45
jonahwilliams added 2 commits January 8, 2025 22:03
@flutter-dashboard
Copy link

flutter-dashboard bot commented Jan 9, 2025

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #161331 at sha 068922c

@flutter-dashboard flutter-dashboard bot added the will affect goldens Changes to golden files label Jan 9, 2025
@jonahwilliams
Copy link
Contributor Author

jonahwilliams commented Jan 9, 2025

@matanlurey PTAL

@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 9, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Jan 9, 2025
Merged via the queue into flutter:master with commit 96dffbe Jan 9, 2025
183 of 184 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 9, 2025
@jmagman
Copy link
Member

jmagman commented Jan 10, 2025

@jonahwilliams I think this commit caused new failures, unfortunately in a build marked flaky:

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8726170373938495281/+/u/run_test.dart_for_flutter_driver_android_shard_and_subshard_None/stdout

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 10, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 10, 2025
@engine-flutter-autoroll
96dffbe [Impeller] fix scaling of trampoline import of GLES textures …
99432f8 
…into Vulkan. (flutter/flutter#161331)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 10, 2025
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 10, 2025
@engine-flutter-autoroll
96dffbe [Impeller] fix scaling of trampoline import of GLES textures …
493ad34 
…into Vulkan. (flutter/flutter#161331)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jan 11, 2025
@engine-flutter-autoroll
Roll Flutter from 4b23b81 to 864d4f5 (50 revisions) (#8408)
f174de6 
Roll Flutter from 4b23b81 to 864d4f5 (50 revisions)

flutter/flutter@4b23b81...864d4f5

2025-01-10 [email protected] Mark complex_layout_scroll_perf_macos__timeline_summary unflaky (flutter/flutter#160997)
2025-01-10 [email protected] Mark hello_world_macos__compile unflaky (flutter/flutter#160998)
2025-01-10 [email protected] Mark animated_complex_opacity_perf_macos__e2e_summary unflaky (flutter/flutter#160996)
2025-01-10 [email protected] Mark integration_ui_test_test_macos unflaky (flutter/flutter#160999)
2025-01-10 [email protected] Mark hot_mode_dev_cycle_macos_target__benchmark unflaky (flutter/flutter#161000)
2025-01-10 [email protected] Add a virtual-display (VD) platform view test, and refactor tests a bit. (flutter/flutter#161349)
2025-01-10 [email protected] Remove `CIRRUS_TASK_NAME` from what I can tell, is always omitted on `LUCI` (flutter/flutter#161391)
2025-01-10 [email protected] Replace the always omitted `CPU` environment variable with `numberOfProcessors`. (flutter/flutter#161392)
2025-01-10 [email protected] We no longer have a separate engine repo. (flutter/flutter#161400)
2025-01-10 [email protected] Update Style-guide-for-Flutter-repo.md (flutter/flutter#161344)
2025-01-09 [email protected] integration_test: Add gitignore of golden image (flutter/flutter#161404)
2025-01-09 [email protected] Fix link to engine docs in CONTRIBUTING.md (flutter/flutter#161401)
2025-01-09 [email protected] Roll Packages from 3fc6b7a to 6554751 (11 revisions) (flutter/flutter#161379)
2025-01-09 [email protected] Add `mouseCursor` parameter to `ReorderableListView` (flutter/flutter#160246)
2025-01-09 [email protected] Remove Cirrus CI from Flutter goldens. (flutter/flutter#161396)
2025-01-09 [email protected] remove`useMaterial3: true,` in from the template (flutter/flutter#160525)
2025-01-09 [email protected] Remove `accept_android_sdk_licenses.sh`, which appears unused. (flutter/flutter#161388)
2025-01-09 [email protected] Roll Dart to Version 3.7.0-312.0.dev (flutter/flutter#161394)
2025-01-09 [email protected] Marks Linux analyzer_benchmark to be flaky (flutter/flutter#161307)
2025-01-09 [email protected] [Impeller] fix scaling of trampoline import of GLES textures into Vulkan. (flutter/flutter#161331)
2025-01-09 [email protected] Support DDC library bundle format and remove support for DDC module format (flutter/flutter#161276)
2025-01-09 [email protected] Remove seemingly stale web Cirrus and "Web Installer" instructions (flutter/flutter#161389)
2025-01-09 [email protected] Proposal to deprecate `webGoldenComparator`. (flutter/flutter#161196)
2025-01-09 [email protected] `ImplicitlyAnimatedWidgetState` code cleanup (flutter/flutter#160567)
2025-01-09 [email protected] Exclude `*texture*` as matching for `a: text input` (flutter/flutter#161354)
2025-01-09 [email protected] [Impeller] add opt in flag for SurfaceControl testing. (flutter/flutter#161353)
2025-01-09 [email protected] Roll Dart to Version 3.7.0-307.0.dev (flutter/flutter#161278)
2025-01-09 [email protected] remove formatter from snippet tool (flutter/flutter#161347)
2025-01-09 [email protected] Refactor keyboard manager tests (flutter/flutter#160637)
2025-01-09 [email protected] [flutter_tools] ignore viewpost ime and samsung spam messages. (flutter/flutter#161199)
2025-01-09 [email protected] Revert "[SwiftPM] Add separate feature flag for the app migration (#158897)" (flutter/flutter#161342)
2025-01-09 [email protected] git ignore .ccls-cache (flutter/flutter#161340)
2025-01-08 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[SwiftPM] Turn on by default (#161275)" (flutter/flutter#161339)
2025-01-08 [email protected] Update engine instructions for monorepo (flutter/flutter#161184)
2025-01-08 [email protected] [Impeller] re-enable Adreno 630 (flutter/flutter#161287)
2025-01-08 [email protected] [SwiftPM] Turn on by default (flutter/flutter#161275)
2025-01-08 [email protected] Make the encoding of a `YamlNode` to a `String` more explicit. (flutter/flutter#161270)
2025-01-08 [email protected] Normalize the translation column of the color matrix. (flutter/flutter#161109)
2025-01-08 [email protected] Rename `native_driver` to `android_{driver_extensions|engine_test}` (flutter/flutter#161263)
2025-01-08 [email protected] [Impeller] reland: fix porterduff shader and handle optimized out texture binding in GLES backend. (flutter/flutter#161326)
2025-01-08 [email protected] Updating AVD Dependency for Android 28 Emulator (flutter/flutter#160978)
2025-01-08 [email protected] Adds onHover and onLongPress to IconButton widget (flutter/flutter#160032)
2025-01-08 [email protected] Marks Linux linux_desktop_impeller to be unflaky (flutter/flutter#161302)
2025-01-08 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] porter duff workarounds for Adreno GPU. (#161273)" (flutter/flutter#161318)
2025-01-08 [email protected] Revert "fixed keyboardDismissBehavior on scroll without a drag" (flutter/flutter#161277)
2025-01-08 [email protected] Revert "use uuid from package:uuid instead of from package:usage" (flutter/flutter#161292)
...
@Piinks Piinks mentioned this pull request Jan 11, 2025
Open
@wang-bin wang-bin mentioned this pull request Feb 7, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025
@engine-flutter-autoroll
96dffbe [Impeller] fix scaling of trampoline import of GLES textures …
09439c6 
…into Vulkan. (flutter/flutter#161331)
@whichname
Copy link

whichname commented Feb 13, 2025

Can this be merged into flutter version 3.27.x ?
I don't have time to upgrade to 3.29 yet

@jonahwilliams
Copy link
Contributor Author

jonahwilliams commented Feb 13, 2025

No

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
96dffbe [Impeller] fix scaling of trampoline import of GLES textures …
7c71815 
…into Vulkan. (flutter/flutter#161331)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025
@engine-flutter-autoroll
96dffbe [Impeller] fix scaling of trampoline import of GLES textures …
6edd75f 
…into Vulkan. (flutter/flutter#161331)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2025
@engine-flutter-autoroll
96dffbe [Impeller] fix scaling of trampoline import of GLES textures …
6587c91 
…into Vulkan. (flutter/flutter#161331)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2025
@engine-flutter-autoroll
96dffbe [Impeller] fix scaling of trampoline import of GLES textures …
06e7f35 
…into Vulkan. (flutter/flutter#161331)
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
@engine-flutter-autoroll @androidseb
Roll Flutter from 4b23b81 to 864d4f5 (50 revisions) (flutter#8408)
0cbe36d 
Roll Flutter from 4b23b81 to 864d4f5 (50 revisions)

flutter/flutter@4b23b81...864d4f5

2025-01-10 [email protected] Mark complex_layout_scroll_perf_macos__timeline_summary unflaky (flutter/flutter#160997)
2025-01-10 [email protected] Mark hello_world_macos__compile unflaky (flutter/flutter#160998)
2025-01-10 [email protected] Mark animated_complex_opacity_perf_macos__e2e_summary unflaky (flutter/flutter#160996)
2025-01-10 [email protected] Mark integration_ui_test_test_macos unflaky (flutter/flutter#160999)
2025-01-10 [email protected] Mark hot_mode_dev_cycle_macos_target__benchmark unflaky (flutter/flutter#161000)
2025-01-10 [email protected] Add a virtual-display (VD) platform view test, and refactor tests a bit. (flutter/flutter#161349)
2025-01-10 [email protected] Remove `CIRRUS_TASK_NAME` from what I can tell, is always omitted on `LUCI` (flutter/flutter#161391)
2025-01-10 [email protected] Replace the always omitted `CPU` environment variable with `numberOfProcessors`. (flutter/flutter#161392)
2025-01-10 [email protected] We no longer have a separate engine repo. (flutter/flutter#161400)
2025-01-10 [email protected] Update Style-guide-for-Flutter-repo.md (flutter/flutter#161344)
2025-01-09 [email protected] integration_test: Add gitignore of golden image (flutter/flutter#161404)
2025-01-09 [email protected] Fix link to engine docs in CONTRIBUTING.md (flutter/flutter#161401)
2025-01-09 [email protected] Roll Packages from 3fc6b7a to 6554751 (11 revisions) (flutter/flutter#161379)
2025-01-09 [email protected] Add `mouseCursor` parameter to `ReorderableListView` (flutter/flutter#160246)
2025-01-09 [email protected] Remove Cirrus CI from Flutter goldens. (flutter/flutter#161396)
2025-01-09 [email protected] remove`useMaterial3: true,` in from the template (flutter/flutter#160525)
2025-01-09 [email protected] Remove `accept_android_sdk_licenses.sh`, which appears unused. (flutter/flutter#161388)
2025-01-09 [email protected] Roll Dart to Version 3.7.0-312.0.dev (flutter/flutter#161394)
2025-01-09 [email protected] Marks Linux analyzer_benchmark to be flaky (flutter/flutter#161307)
2025-01-09 [email protected] [Impeller] fix scaling of trampoline import of GLES textures into Vulkan. (flutter/flutter#161331)
2025-01-09 [email protected] Support DDC library bundle format and remove support for DDC module format (flutter/flutter#161276)
2025-01-09 [email protected] Remove seemingly stale web Cirrus and "Web Installer" instructions (flutter/flutter#161389)
2025-01-09 [email protected] Proposal to deprecate `webGoldenComparator`. (flutter/flutter#161196)
2025-01-09 [email protected] `ImplicitlyAnimatedWidgetState` code cleanup (flutter/flutter#160567)
2025-01-09 [email protected] Exclude `*texture*` as matching for `a: text input` (flutter/flutter#161354)
2025-01-09 [email protected] [Impeller] add opt in flag for SurfaceControl testing. (flutter/flutter#161353)
2025-01-09 [email protected] Roll Dart to Version 3.7.0-307.0.dev (flutter/flutter#161278)
2025-01-09 [email protected] remove formatter from snippet tool (flutter/flutter#161347)
2025-01-09 [email protected] Refactor keyboard manager tests (flutter/flutter#160637)
2025-01-09 [email protected] [flutter_tools] ignore viewpost ime and samsung spam messages. (flutter/flutter#161199)
2025-01-09 [email protected] Revert "[SwiftPM] Add separate feature flag for the app migration (#158897)" (flutter/flutter#161342)
2025-01-09 [email protected] git ignore .ccls-cache (flutter/flutter#161340)
2025-01-08 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[SwiftPM] Turn on by default (#161275)" (flutter/flutter#161339)
2025-01-08 [email protected] Update engine instructions for monorepo (flutter/flutter#161184)
2025-01-08 [email protected] [Impeller] re-enable Adreno 630 (flutter/flutter#161287)
2025-01-08 [email protected] [SwiftPM] Turn on by default (flutter/flutter#161275)
2025-01-08 [email protected] Make the encoding of a `YamlNode` to a `String` more explicit. (flutter/flutter#161270)
2025-01-08 [email protected] Normalize the translation column of the color matrix. (flutter/flutter#161109)
2025-01-08 [email protected] Rename `native_driver` to `android_{driver_extensions|engine_test}` (flutter/flutter#161263)
2025-01-08 [email protected] [Impeller] reland: fix porterduff shader and handle optimized out texture binding in GLES backend. (flutter/flutter#161326)
2025-01-08 [email protected] Updating AVD Dependency for Android 28 Emulator (flutter/flutter#160978)
2025-01-08 [email protected] Adds onHover and onLongPress to IconButton widget (flutter/flutter#160032)
2025-01-08 [email protected] Marks Linux linux_desktop_impeller to be unflaky (flutter/flutter#161302)
2025-01-08 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] porter duff workarounds for Adreno GPU. (#161273)" (flutter/flutter#161318)
2025-01-08 [email protected] Revert "fixed keyboardDismissBehavior on scroll without a drag" (flutter/flutter#161277)
2025-01-08 [email protected] Revert "use uuid from package:uuid instead of from package:usage" (flutter/flutter#161292)
...
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
@engine-flutter-autoroll @FMorschel
Roll Flutter from 4b23b81 to 864d4f5 (50 revisions) (flutter#8408)
1c1cbd6 
Roll Flutter from 4b23b81 to 864d4f5 (50 revisions)

flutter/flutter@4b23b81...864d4f5

2025-01-10 [email protected] Mark complex_layout_scroll_perf_macos__timeline_summary unflaky (flutter/flutter#160997)
2025-01-10 [email protected] Mark hello_world_macos__compile unflaky (flutter/flutter#160998)
2025-01-10 [email protected] Mark animated_complex_opacity_perf_macos__e2e_summary unflaky (flutter/flutter#160996)
2025-01-10 [email protected] Mark integration_ui_test_test_macos unflaky (flutter/flutter#160999)
2025-01-10 [email protected] Mark hot_mode_dev_cycle_macos_target__benchmark unflaky (flutter/flutter#161000)
2025-01-10 [email protected] Add a virtual-display (VD) platform view test, and refactor tests a bit. (flutter/flutter#161349)
2025-01-10 [email protected] Remove `CIRRUS_TASK_NAME` from what I can tell, is always omitted on `LUCI` (flutter/flutter#161391)
2025-01-10 [email protected] Replace the always omitted `CPU` environment variable with `numberOfProcessors`. (flutter/flutter#161392)
2025-01-10 [email protected] We no longer have a separate engine repo. (flutter/flutter#161400)
2025-01-10 [email protected] Update Style-guide-for-Flutter-repo.md (flutter/flutter#161344)
2025-01-09 [email protected] integration_test: Add gitignore of golden image (flutter/flutter#161404)
2025-01-09 [email protected] Fix link to engine docs in CONTRIBUTING.md (flutter/flutter#161401)
2025-01-09 [email protected] Roll Packages from 3fc6b7a to 6554751 (11 revisions) (flutter/flutter#161379)
2025-01-09 [email protected] Add `mouseCursor` parameter to `ReorderableListView` (flutter/flutter#160246)
2025-01-09 [email protected] Remove Cirrus CI from Flutter goldens. (flutter/flutter#161396)
2025-01-09 [email protected] remove`useMaterial3: true,` in from the template (flutter/flutter#160525)
2025-01-09 [email protected] Remove `accept_android_sdk_licenses.sh`, which appears unused. (flutter/flutter#161388)
2025-01-09 [email protected] Roll Dart to Version 3.7.0-312.0.dev (flutter/flutter#161394)
2025-01-09 [email protected] Marks Linux analyzer_benchmark to be flaky (flutter/flutter#161307)
2025-01-09 [email protected] [Impeller] fix scaling of trampoline import of GLES textures into Vulkan. (flutter/flutter#161331)
2025-01-09 [email protected] Support DDC library bundle format and remove support for DDC module format (flutter/flutter#161276)
2025-01-09 [email protected] Remove seemingly stale web Cirrus and "Web Installer" instructions (flutter/flutter#161389)
2025-01-09 [email protected] Proposal to deprecate `webGoldenComparator`. (flutter/flutter#161196)
2025-01-09 [email protected] `ImplicitlyAnimatedWidgetState` code cleanup (flutter/flutter#160567)
2025-01-09 [email protected] Exclude `*texture*` as matching for `a: text input` (flutter/flutter#161354)
2025-01-09 [email protected] [Impeller] add opt in flag for SurfaceControl testing. (flutter/flutter#161353)
2025-01-09 [email protected] Roll Dart to Version 3.7.0-307.0.dev (flutter/flutter#161278)
2025-01-09 [email protected] remove formatter from snippet tool (flutter/flutter#161347)
2025-01-09 [email protected] Refactor keyboard manager tests (flutter/flutter#160637)
2025-01-09 [email protected] [flutter_tools] ignore viewpost ime and samsung spam messages. (flutter/flutter#161199)
2025-01-09 [email protected] Revert "[SwiftPM] Add separate feature flag for the app migration (#158897)" (flutter/flutter#161342)
2025-01-09 [email protected] git ignore .ccls-cache (flutter/flutter#161340)
2025-01-08 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[SwiftPM] Turn on by default (#161275)" (flutter/flutter#161339)
2025-01-08 [email protected] Update engine instructions for monorepo (flutter/flutter#161184)
2025-01-08 [email protected] [Impeller] re-enable Adreno 630 (flutter/flutter#161287)
2025-01-08 [email protected] [SwiftPM] Turn on by default (flutter/flutter#161275)
2025-01-08 [email protected] Make the encoding of a `YamlNode` to a `String` more explicit. (flutter/flutter#161270)
2025-01-08 [email protected] Normalize the translation column of the color matrix. (flutter/flutter#161109)
2025-01-08 [email protected] Rename `native_driver` to `android_{driver_extensions|engine_test}` (flutter/flutter#161263)
2025-01-08 [email protected] [Impeller] reland: fix porterduff shader and handle optimized out texture binding in GLES backend. (flutter/flutter#161326)
2025-01-08 [email protected] Updating AVD Dependency for Android 28 Emulator (flutter/flutter#160978)
2025-01-08 [email protected] Adds onHover and onLongPress to IconButton widget (flutter/flutter#160032)
2025-01-08 [email protected] Marks Linux linux_desktop_impeller to be unflaky (flutter/flutter#161302)
2025-01-08 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] porter duff workarounds for Adreno GPU. (#161273)" (flutter/flutter#161318)
2025-01-08 [email protected] Revert "fixed keyboardDismissBehavior on scroll without a drag" (flutter/flutter#161277)
2025-01-08 [email protected] Revert "use uuid from package:uuid instead of from package:usage" (flutter/flutter#161292)
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matanlurey matanlurey matanlurey approved these changes

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems engine flutter/engine related. See also e: labels. platform-android Android applications specifically will affect goldens Changes to golden files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Android Platform Views pixelated when imported via SurfaceTexture trampoline on Vulkan backend.

4 participants

@jonahwilliams @jmagman @whichname @matanlurey