Remove `--template=skeleton` and add a placeholder error message instead. #160695

matanlurey · 2024-12-20T23:29:33Z

Closes #160673.

Does the following:

Renames FlutterProjectType to FlutterTemplateType; did some enhanced enum cleanups while at it
Creates a hierarchy of RemovedFlutterTemplateType from ParsedFlutterTemplateType
Removes the skeleton directory
Merges app_shared back into app (no longer required now that skeleton is removed)

Final cleanups are tracked in #160692.

(Added @zanderso just to spot check this is what he meant by #160673 (comment))

jonahwilliams

Looks good from my end but I would let @andrewkolos take a look when he is available.

matanlurey · 2024-12-21T00:28:05Z

Some hardcoded-test assumptions still need to be updated. I'll fix those up Monday.

…plate

andrewkolos

Implementation LGTM. Feel free to re-request if tests end up needing significant re-writes

zanderso

Yes, this is what I was thinking.

zanderso · 2024-12-24T17:15:50Z

packages/flutter_tools/lib/src/flutter_project_metadata.dart

+        'Formerly generated a list view / detail view Flutter application that '
+        'followed some community best practices. For up to date resources, see '
+        'https://flutter.github.io/samples, https://docs.flutter.dev/codelabs, '
+        'and external resources such as https://flutter-builder.app/.',


nit: external -> "community" or "third-party".

zanderso · 2024-12-24T17:17:03Z

packages/flutter_tools/lib/src/flutter_project_metadata.dart

+enum RemovedFlutterTemplateType implements ParsedFlutterTemplateType {
+  skeleton(
+    helpText:
+        'Formerly generated a list view / detail view Flutter application that '


@ericwindmill sgty?

Post-merge feedback from #160695. Feel free to suggest other (minor) changes, as the bulk of the work is already complete.

…age instead. (flutter/flutter#160695)

flutter/flutter#160695

matanlurey added 3 commits December 20, 2024 14:33

Remove flutter create -t skeleton.

9466762

Remove references to app_shared.

6275923

Fix, add a test for --template=skeleton.

9eaa2b3

matanlurey requested review from zanderso and andrewkolos December 20, 2024 23:29

github-actions bot added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. labels Dec 20, 2024

matanlurey requested a review from jonahwilliams December 20, 2024 23:33

jonahwilliams reviewed Dec 20, 2024

View reviewed changes

Merge remote-tracking branch 'upstream/main' into remove-skeleton-tem…

6ffd378

…plate

andrewkolos approved these changes Dec 23, 2024

View reviewed changes

matanlurey added 4 commits December 23, 2024 11:37

Get a better error message when create_test exists fail.

306a2d5

Delete now defunct skeleton folder, which should fix integration tests.

4958a2c

Fix path to app instead of app_shared.

6c94f97

Add reverse gitignore and re-add deleted files.

c336b78

github-actions bot added engine flutter/engine related. See also e: labels. a: desktop Running on desktop labels Dec 23, 2024

matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 24, 2024

auto-submit bot added this pull request to the merge queue Dec 24, 2024

Merged via the queue into flutter:master with commit 0ffc4ce Dec 24, 2024
175 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 24, 2024

zanderso reviewed Dec 24, 2024

View reviewed changes

matanlurey added a commit to matanlurey/flutter that referenced this pull request Dec 26, 2024

Tweak language post-merge of flutter#160695.

48a430d

matanlurey mentioned this pull request Dec 26, 2024

Tweak language post-merge of #160695. #160876

Merged

github-merge-queue bot pushed a commit that referenced this pull request Dec 27, 2024

Tweak language post-merge of #160695. (#160876)

cdce287

Post-merge feedback from #160695. Feel free to suggest other (minor) changes, as the bulk of the work is already complete.

engine-flutter-autoroll mentioned this pull request Jan 6, 2025

Roll Flutter from 29a6c648ca4d to 0c3359df8c83 (121 revisions) flutter/packages#8376

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 6, 2025

0ffc4ce Remove --template=skeleton and add a placeholder error mess…

afa3f22

…age instead. (flutter/flutter#160695)

engine-flutter-autoroll mentioned this pull request Jan 6, 2025

Roll Flutter from 29a6c648ca4d to 6d729b6d1d2e (122 revisions) flutter/packages#8377

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025

0ffc4ce Remove --template=skeleton and add a placeholder error mess…

ee6d9e9

…age instead. (flutter/flutter#160695)

engine-flutter-autoroll mentioned this pull request Jan 7, 2025

Roll Flutter from 29a6c648ca4d to b55290697705 (141 revisions) flutter/packages#8381

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025

0ffc4ce Remove --template=skeleton and add a placeholder error mess…

a10e39f

…age instead. (flutter/flutter#160695)

engine-flutter-autoroll mentioned this pull request Jan 7, 2025

Roll Flutter from 29a6c648ca4d to e66e04f39ffa (142 revisions) flutter/packages#8382

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025

0ffc4ce Remove --template=skeleton and add a placeholder error mess…

267a868

…age instead. (flutter/flutter#160695)

engine-flutter-autoroll mentioned this pull request Jan 7, 2025

Roll Flutter from 29a6c648ca4d to bb4628e0f046 (143 revisions) flutter/packages#8383

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025

0ffc4ce Remove --template=skeleton and add a placeholder error mess…

e55ab97

…age instead. (flutter/flutter#160695)

engine-flutter-autoroll mentioned this pull request Jan 7, 2025

Roll Flutter from 29a6c648ca4d to e30bf8523123 (144 revisions) flutter/packages#8385

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025

0ffc4ce Remove --template=skeleton and add a placeholder error mess…

8eaf2d5

…age instead. (flutter/flutter#160695)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025

0ffc4ce Remove --template=skeleton and add a placeholder error mess…

f7e8c56

…age instead. (flutter/flutter#160695)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025

0ffc4ce Remove --template=skeleton and add a placeholder error mess…

3bcdb4b

…age instead. (flutter/flutter#160695)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025

0ffc4ce Remove --template=skeleton and add a placeholder error mess…

2982a18

…age instead. (flutter/flutter#160695)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025

0ffc4ce Remove --template=skeleton and add a placeholder error mess…

42a8499

…age instead. (flutter/flutter#160695)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025

0ffc4ce Remove --template=skeleton and add a placeholder error mess…

26c7ec3

…age instead. (flutter/flutter#160695)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025

0ffc4ce Remove --template=skeleton and add a placeholder error mess…

573fd47

…age instead. (flutter/flutter#160695)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025

0ffc4ce Remove --template=skeleton and add a placeholder error mess…

260a5ed

…age instead. (flutter/flutter#160695)

StephenWithPH mentioned this pull request Jan 16, 2025

use Gradle's Kotlin DSL in plugin templates #161703

Open

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025

0ffc4ce Remove --template=skeleton and add a placeholder error mess…

5d3a49f

…age instead. (flutter/flutter#160695)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025

0ffc4ce Remove --template=skeleton and add a placeholder error mess…

6ede15d

…age instead. (flutter/flutter#160695)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025

0ffc4ce Remove --template=skeleton and add a placeholder error mess…

6073e69

…age instead. (flutter/flutter#160695)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2025

0ffc4ce Remove --template=skeleton and add a placeholder error mess…

f49cc6e

…age instead. (flutter/flutter#160695)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2025

0ffc4ce Remove --template=skeleton and add a placeholder error mess…

6ac4fea

…age instead. (flutter/flutter#160695)

JSUYA added a commit to JSUYA/flutter-tizen that referenced this pull request Mar 13, 2025

Change FlutterProjectType to FlutterTemplateType

b55406d

flutter/flutter#160695

JSUYA added a commit to JSUYA/flutter-tizen that referenced this pull request Mar 13, 2025

Merges app_shaed into app

accf825

flutter/flutter#160695

JSUYA added a commit to JSUYA/flutter-tizen that referenced this pull request Apr 10, 2025

Change FlutterProjectType to FlutterTemplateType

30b9c1d

flutter/flutter#160695

JSUYA added a commit to JSUYA/flutter-tizen that referenced this pull request Apr 10, 2025

Merges app_shaed into app

fb83e0f

flutter/flutter#160695

JSUYA added a commit to JSUYA/flutter-tizen that referenced this pull request Apr 11, 2025

Change FlutterProjectType to FlutterTemplateType

18c0ecf

flutter/flutter#160695

JSUYA added a commit to JSUYA/flutter-tizen that referenced this pull request Apr 11, 2025

Merges app_shaed into app

1bbccbd

flutter/flutter#160695

JSUYA added a commit to JSUYA/flutter-tizen that referenced this pull request Apr 15, 2025

Change FlutterProjectType to FlutterTemplateType

7449e39

flutter/flutter#160695

JSUYA added a commit to JSUYA/flutter-tizen that referenced this pull request Apr 15, 2025

Merges app_shaed into app

3198d71

flutter/flutter#160695

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Remove `--template=skeleton` and add a placeholder error message instead. #160695

Remove `--template=skeleton` and add a placeholder error message instead. #160695

matanlurey commented Dec 20, 2024 •

edited

Loading

Uh oh!

jonahwilliams left a comment

Uh oh!

matanlurey commented Dec 21, 2024

Uh oh!

andrewkolos left a comment •

edited

Loading

Uh oh!

Uh oh!

zanderso left a comment

Uh oh!

zanderso Dec 24, 2024

Uh oh!

zanderso Dec 24, 2024

Uh oh!

Uh oh!

Remove --template=skeleton and add a placeholder error message instead. #160695

Remove --template=skeleton and add a placeholder error message instead. #160695

Conversation

matanlurey commented Dec 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jonahwilliams left a comment

Choose a reason for hiding this comment

Uh oh!

matanlurey commented Dec 21, 2024

Uh oh!

andrewkolos left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

zanderso left a comment

Choose a reason for hiding this comment

Uh oh!

zanderso Dec 24, 2024

Choose a reason for hiding this comment

Uh oh!

zanderso Dec 24, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Remove `--template=skeleton` and add a placeholder error message instead. #160695

Remove `--template=skeleton` and add a placeholder error message instead. #160695

matanlurey commented Dec 20, 2024 •

edited

Loading

andrewkolos left a comment •

edited

Loading