Skip to content

Add a test of an Android platform view that draws a gradient #153878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 23, 2024
Merged

Add a test of an Android platform view that draws a gradient #153878

merged 8 commits into from
Aug 23, 2024

Conversation

@matanlurey
Copy link
Contributor

@matanlurey matanlurey commented Aug 21, 2024

Closes #152376.

The gradient, for posterity, looks like this:

Let's see if CI agrees!

/cc @johnmccutchan

@github-actions github-actions bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Aug 21, 2024
jonahwilliams
jonahwilliams approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nit

...ver_test/android/app/src/main/kotlin/com/example/android_driver_test/GradientPlatformView.kt Outdated
@@ -0,0 +1,56 @@
package com.example.android_driver_test
Copy link
Contributor

@jonahwilliams jonahwilliams Aug 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

License header?

Copy link
Contributor Author

@matanlurey matanlurey Aug 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@johnmccutchan
Copy link
Contributor

johnmccutchan commented Aug 21, 2024

Woo hoo 🎉

@matanlurey matanlurey mentioned this pull request Aug 21, 2024
Closed
@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 23, 2024
@auto-submit auto-submit bot merged commit 5e19438 into flutter:master Aug 23, 2024
@matanlurey matanlurey deleted the android-driver-blue-rectangle branch August 23, 2024 18:25
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 23, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 23, 2024
@engine-flutter-autoroll
5e19438 Add a test of an Android platform view that draws a gradient (f…
784b9d0 
…lutter/flutter#153878)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 24, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 24, 2024
@engine-flutter-autoroll
5e19438 Add a test of an Android platform view that draws a gradient (f…
42e4c83 
…lutter/flutter#153878)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 24, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 24, 2024
@engine-flutter-autoroll
5e19438 Add a test of an Android platform view that draws a gradient (f…
8b37533 
…lutter/flutter#153878)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 25, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 25, 2024
@engine-flutter-autoroll
5e19438 Add a test of an Android platform view that draws a gradient (f…
f3c3525 
…lutter/flutter#153878)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 26, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 26, 2024
@engine-flutter-autoroll
5e19438 Add a test of an Android platform view that draws a gradient (f…
2c1108a 
…lutter/flutter#153878)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 26, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 26, 2024
@engine-flutter-autoroll
5e19438 Add a test of an Android platform view that draws a gradient (f…
5aec40a 
…lutter/flutter#153878)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 26, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
5e19438 Add a test of an Android platform view that draws a gradient (f…
33f79d8 
…lutter/flutter#153878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
5e19438 Add a test of an Android platform view that draws a gradient (f…
5006f6a 
…lutter/flutter#153878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
5e19438 Add a test of an Android platform view that draws a gradient (f…
4c98948 
…lutter/flutter#153878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
5e19438 Add a test of an Android platform view that draws a gradient (f…
0195d63 
…lutter/flutter#153878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
5e19438 Add a test of an Android platform view that draws a gradient (f…
d9899ab 
…lutter/flutter#153878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
5e19438 Add a test of an Android platform view that draws a gradient (f…
1364649 
…lutter/flutter#153878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
5e19438 Add a test of an Android platform view that draws a gradient (f…
908c221 
…lutter/flutter#153878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 31, 2024
@engine-flutter-autoroll
5e19438 Add a test of an Android platform view that draws a gradient (f…
ba687a4 
…lutter/flutter#153878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 31, 2024
@engine-flutter-autoroll
5e19438 Add a test of an Android platform view that draws a gradient (f…
c551410 
…lutter/flutter#153878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2024
@engine-flutter-autoroll
5e19438 Add a test of an Android platform view that draws a gradient (f…
38de66e 
…lutter/flutter#153878)
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
@matanlurey @Buchimi
Add a test of an Android platform view that draws a gradient (flutter…
1b4df3b 
…#153878)

Closes flutter#152376.

The gradient, for posterity, looks like this:

<img src="https://github.com/user-attachments/assets/bed9599a-4e16-499c-af79-b51980095e89" width="150">

Let's see if CI agrees!

/cc @johnmccutchan
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
@engine-flutter-autoroll
5e19438 Add a test of an Android platform view that draws a gradient (f…
f4b3bbb 
…lutter/flutter#153878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
@engine-flutter-autoroll
5e19438 Add a test of an Android platform view that draws a gradient (f…
24f0588 
…lutter/flutter#153878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
@engine-flutter-autoroll
5e19438 Add a test of an Android platform view that draws a gradient (f…
1d7e021 
…lutter/flutter#153878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
@engine-flutter-autoroll
5e19438 Add a test of an Android platform view that draws a gradient (f…
9f1bcc8 
…lutter/flutter#153878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
@engine-flutter-autoroll
5e19438 Add a test of an Android platform view that draws a gradient (f…
7b6e86c 
…lutter/flutter#153878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
@engine-flutter-autoroll
5e19438 Add a test of an Android platform view that draws a gradient (f…
2b7045c 
…lutter/flutter#153878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
5e19438 Add a test of an Android platform view that draws a gradient (f…
96cafc6 
…lutter/flutter#153878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
5e19438 Add a test of an Android platform view that draws a gradient (f…
b30b630 
…lutter/flutter#153878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
5e19438 Add a test of an Android platform view that draws a gradient (f…
0b8634e 
…lutter/flutter#153878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
5e19438 Add a test of an Android platform view that draws a gradient (f…
2ea6d02 
…lutter/flutter#153878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
5e19438 Add a test of an Android platform view that draws a gradient (f…
5921ca3 
…lutter/flutter#153878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
5e19438 Add a test of an Android platform view that draws a gradient (f…
ff76acc 
…lutter/flutter#153878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
5e19438 Add a test of an Android platform view that draws a gradient (f…
b2534ed 
…lutter/flutter#153878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
5e19438 Add a test of an Android platform view that draws a gradient (f…
690f79a 
…lutter/flutter#153878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
5e19438 Add a test of an Android platform view that draws a gradient (f…
6740359 
…lutter/flutter#153878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
5e19438 Add a test of an Android platform view that draws a gradient (f…
3164e99 
…lutter/flutter#153878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
5e19438 Add a test of an Android platform view that draws a gradient (f…
45efbf1 
…lutter/flutter#153878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024
@engine-flutter-autoroll
5e19438 Add a test of an Android platform view that draws a gradient (f…
21cc6a1 
…lutter/flutter#153878)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 12, 2024
@engine-flutter-autoroll
5e19438 Add a test of an Android platform view that draws a gradient (f…
f5d41b9 
…lutter/flutter#153878)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

At least 1 on-device UI test of an Android platform view working on CI

3 participants

@matanlurey @johnmccutchan @jonahwilliams