Skip to content

Do not silently fail pub get even if output-mode is "none" #153596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 22, 2024
Merged

Do not silently fail pub get even if output-mode is "none" #153596

merged 5 commits into from
Aug 22, 2024

Conversation

@matanlurey
Copy link
Contributor

@matanlurey matanlurey commented Aug 16, 2024

I am making an assumption OutputMode.none should really mean OutputMode.failuresOnly, that is, if we ever get a non-zero exit code, we still want to know why. If I've somehow misunderstood that, LMK and I'm happy to revert this PR or make adjustments.

This fixes the bug where if you were to do:

git clone https://github.com/myuser/fork-of-flutter
cd fork-of-flutter
./bin/flutter update-packages

You now get:

  1. An actual error message, versus no output at all.
  2. A warning that a common reason is not tracking a remote, with instructions to fix it.

Closes #148569.

@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Aug 16, 2024
@matanlurey
Copy link
Contributor Author

matanlurey commented Aug 16, 2024

One failure is essentially a lint - I can fix that.

The other is a test that expected no failure (pub get 66) but does produce a non-zero exit code.

I suspect updating the test is the right call, but I'm also not 100% sure.

andrewkolos
andrewkolos approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@andrewkolos andrewkolos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@andrewkolos
Copy link
Contributor

andrewkolos commented Aug 19, 2024

I spoke a bit soon! Looks like this is failing test/general.shard/dart/pub_get_test.dart: pub get 66 shows message from pub

@matanlurey matanlurey requested a review from andrewkolos August 21, 2024 16:01
@andrewkolos
Copy link
Contributor

andrewkolos commented Aug 21, 2024

This is failing customer_testing due to seemingly unrelated compilation errors 🤷. I wonder what's going on and whether a rebase/merge would fix this PR.

@matanlurey matanlurey merged commit a9e94d9 into flutter:master Aug 22, 2024
@matanlurey matanlurey deleted the flutter-update-packages-silent-failure branch August 22, 2024 16:12
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 22, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 22, 2024
@engine-flutter-autoroll
a9e94d9 Do not silently fail pub get even if output-mode is "none" (f…
815e608 
…lutter/flutter#153596)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 22, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 22, 2024
@engine-flutter-autoroll
a9e94d9 Do not silently fail pub get even if output-mode is "none" (f…
53f9a8d 
…lutter/flutter#153596)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 22, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 22, 2024
@engine-flutter-autoroll
a9e94d9 Do not silently fail pub get even if output-mode is "none" (f…
1061185 
…lutter/flutter#153596)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 22, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 22, 2024
@engine-flutter-autoroll
a9e94d9 Do not silently fail pub get even if output-mode is "none" (f…
8a0a476 
…lutter/flutter#153596)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 23, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 23, 2024
@engine-flutter-autoroll
a9e94d9 Do not silently fail pub get even if output-mode is "none" (f…
8910a94 
…lutter/flutter#153596)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 23, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 23, 2024
@engine-flutter-autoroll
a9e94d9 Do not silently fail pub get even if output-mode is "none" (f…
899d9e0 
…lutter/flutter#153596)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 23, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 23, 2024
@engine-flutter-autoroll
a9e94d9 Do not silently fail pub get even if output-mode is "none" (f…
e5302b2 
…lutter/flutter#153596)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 23, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
a9e94d9 Do not silently fail pub get even if output-mode is "none" (f…
9001f0e 
…lutter/flutter#153596)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
a9e94d9 Do not silently fail pub get even if output-mode is "none" (f…
becb966 
…lutter/flutter#153596)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
a9e94d9 Do not silently fail pub get even if output-mode is "none" (f…
4cc9f56 
…lutter/flutter#153596)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
a9e94d9 Do not silently fail pub get even if output-mode is "none" (f…
2720cf3 
…lutter/flutter#153596)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
a9e94d9 Do not silently fail pub get even if output-mode is "none" (f…
e8d4799 
…lutter/flutter#153596)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
a9e94d9 Do not silently fail pub get even if output-mode is "none" (f…
cc64ad4 
…lutter/flutter#153596)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
a9e94d9 Do not silently fail pub get even if output-mode is "none" (f…
8b93922 
…lutter/flutter#153596)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 31, 2024
@engine-flutter-autoroll
a9e94d9 Do not silently fail pub get even if output-mode is "none" (f…
ee37449 
…lutter/flutter#153596)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 31, 2024
@engine-flutter-autoroll
a9e94d9 Do not silently fail pub get even if output-mode is "none" (f…
d073924 
…lutter/flutter#153596)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2024
@engine-flutter-autoroll
a9e94d9 Do not silently fail pub get even if output-mode is "none" (f…
3106f93 
…lutter/flutter#153596)
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
@matanlurey @Buchimi
Do not silently fail pub get even if output-mode is "none" (flutter…
c77548a 
…#153596)

I am making an assumption `OutputMode.none` should _really_ mean
`OutputMode.failuresOnly`, that is, if we ever get a non-zero exit code,
we still want to know why. If I've somehow misunderstood that, LMK and
I'm happy to revert this PR or make adjustments.

This fixes the bug where if you were to do:

```sh
git clone https://github.com/myuser/fork-of-flutter
cd fork-of-flutter
./bin/flutter update-packages
```

You now get:

1. An actual error message, versus no output at all.
2. A warning that a common reason is not tracking a remote, with
instructions to fix it.

Closes flutter#148569.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
@engine-flutter-autoroll
a9e94d9 Do not silently fail pub get even if output-mode is "none" (f…
d22b856 
…lutter/flutter#153596)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
@engine-flutter-autoroll
a9e94d9 Do not silently fail pub get even if output-mode is "none" (f…
bb8f3ff 
…lutter/flutter#153596)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
@engine-flutter-autoroll
a9e94d9 Do not silently fail pub get even if output-mode is "none" (f…
446bfa3 
…lutter/flutter#153596)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
@engine-flutter-autoroll
a9e94d9 Do not silently fail pub get even if output-mode is "none" (f…
c965390 
…lutter/flutter#153596)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
@engine-flutter-autoroll
a9e94d9 Do not silently fail pub get even if output-mode is "none" (f…
7118ef7 
…lutter/flutter#153596)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
@engine-flutter-autoroll
a9e94d9 Do not silently fail pub get even if output-mode is "none" (f…
d1fa4a5 
…lutter/flutter#153596)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
a9e94d9 Do not silently fail pub get even if output-mode is "none" (f…
c12b17e 
…lutter/flutter#153596)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
a9e94d9 Do not silently fail pub get even if output-mode is "none" (f…
ec07d50 
…lutter/flutter#153596)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
a9e94d9 Do not silently fail pub get even if output-mode is "none" (f…
547d54b 
…lutter/flutter#153596)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
a9e94d9 Do not silently fail pub get even if output-mode is "none" (f…
40caae9 
…lutter/flutter#153596)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
a9e94d9 Do not silently fail pub get even if output-mode is "none" (f…
f4e62d5 
…lutter/flutter#153596)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
a9e94d9 Do not silently fail pub get even if output-mode is "none" (f…
dfe6403 
…lutter/flutter#153596)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
a9e94d9 Do not silently fail pub get even if output-mode is "none" (f…
7650cfe 
…lutter/flutter#153596)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
a9e94d9 Do not silently fail pub get even if output-mode is "none" (f…
378aac5 
…lutter/flutter#153596)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
a9e94d9 Do not silently fail pub get even if output-mode is "none" (f…
d71ef90 
…lutter/flutter#153596)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
a9e94d9 Do not silently fail pub get even if output-mode is "none" (f…
21fd4af 
…lutter/flutter#153596)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
a9e94d9 Do not silently fail pub get even if output-mode is "none" (f…
582cc2c 
…lutter/flutter#153596)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024
@engine-flutter-autoroll
a9e94d9 Do not silently fail pub get even if output-mode is "none" (f…
2557da3 
…lutter/flutter#153596)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 12, 2024
@engine-flutter-autoroll
a9e94d9 Do not silently fail pub get even if output-mode is "none" (f…
b0a1749 
…lutter/flutter#153596)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johnmccutchan johnmccutchan Awaiting requested review from johnmccutchan

@andrewkolos andrewkolos Awaiting requested review from andrewkolos

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

flutter update-packages can fail silently

2 participants

@matanlurey @andrewkolos