Skip to content

[web] Change --web-renderer default from auto to canvaskit #149773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 10, 2024
Merged

[web] Change --web-renderer default from auto to canvaskit #149773

merged 3 commits into from
Jun 10, 2024

Conversation

@mdebbar
Copy link
Contributor

@mdebbar mdebbar commented Jun 5, 2024 •
edited
Loading

  • When --web-renderer is omitted, keep the value null until it later materializes to either canvaskit or skwasm.
  • No more hardcoded defaults anywhere. We use WebRendererMode.defaultForJs/defaultForWasm instead.
  • When in --wasm mode, the JS fallback is now canvaskit instead of auto.
  • Add test for defaulting to skwasm when --wasm is enabled.

Fixes #149826

@mdebbar mdebbar requested a review from eyebrowsoffire June 5, 2024 22:03
@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jun 5, 2024
@mdebbar mdebbar mentioned this pull request Jun 6, 2024
Merged
3 tasks
sfshaza2 pushed a commit to flutter/website that referenced this pull request Jun 6, 2024
@mdebbar
[web] Change --web-renderer default from auto to canvaskit (#10714
e82c589 
)

Changes the documentation of the default renderer on web. The default
renderer is changing from `auto` to `canvaskit`.

_This PR is mostly moving things around with no new content being
added._

The PR making the code changes:
flutter/flutter#149773
The issue: flutter/flutter#149826

## Presubmit checklist

- [x] This PR doesn’t contain automatically generated corrections
(Grammarly or similar).
- [x] This PR follows the [Google Developer Documentation Style
Guidelines](https://developers.google.com/style) — for example, it
doesn’t use _i.e._ or _e.g._, and it avoids _I_ and _we_ (first person).
- [x] This PR uses [semantic line
breaks](https://github.com/dart-lang/site-shared/blob/main/doc/writing-for-dart-and-flutter-websites.md#semantic-line-breaks)
of 80 characters or fewer.
eyebrowsoffire
eyebrowsoffire reviewed Jun 6, 2024
View reviewed changes
Copy link
Contributor

@eyebrowsoffire eyebrowsoffire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One small nit.

packages/flutter_tools/test/general.shard/build_system/targets/web_test.dart Outdated
JsCompilerConfig(noFrequencyBasedMinification: true),
JsCompilerConfig(sourceMaps: false),
JsCompilerConfig(renderer: WebRendererMode.canvaskit),
JsCompilerConfig(renderer: WebRendererMode.skwasm),
Copy link
Contributor

@eyebrowsoffire eyebrowsoffire Jun 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should do WebRendererMode.auto or WebRendererMode.html here for this test, I think. JsCompilerConfig with a skwasm renderer mode, while it won't throw at this particular layer it isn't a logically valid or supported combination, so it's weird to use it in the test.

Copy link
Contributor Author

@mdebbar mdebbar Jun 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only reason I used skwasm instead of html is because I didn't want to change it again when we remove the html renderer.

But I see what you're saying. I'll use html for now, and later remove this line entirely when there's no more html renderer.

eyebrowsoffire
eyebrowsoffire approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@eyebrowsoffire eyebrowsoffire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant to approve earlier.

@mdebbar mdebbar mentioned this pull request Jun 7, 2024
Merged
3 tasks
@mdebbar mdebbar added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 10, 2024
@auto-submit auto-submit bot merged commit ee10d2f into flutter:master Jun 10, 2024
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 11, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 11, 2024
@engine-flutter-autoroll
ee10d2f [web] Change --web-renderer default from auto to `canvask…
f148c39 
…it` (flutter/flutter#149773)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 11, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 11, 2024
@engine-flutter-autoroll
ee10d2f [web] Change --web-renderer default from auto to `canvask…
f2b4f4c 
…it` (flutter/flutter#149773)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jun 11, 2024
@engine-flutter-autoroll
Roll Flutter from 32081aa to 14df7be (21 revisions) (#6907)
8c24fd4 
flutter/flutter@32081aa...14df7be

2024-06-11 [email protected] Revert "Add tests for scaffold drawer and end drawer" (flutter/flutter#150045)
2024-06-11 [email protected] Add tests for scaffold drawer and end drawer (flutter/flutter#149383)
2024-06-11 [email protected] Add high-contrast theme (flutter/flutter#149779)
2024-06-11 [email protected] Manual Pub Roll (flutter/flutter#150025)
2024-06-10 [email protected] [docs] Per-platform desktop triage instructions (flutter/flutter#150019)
2024-06-10 [email protected] Fix copy-paste-o in MethodChannel.invokeListMethod doc (flutter/flutter#149976)
2024-06-10 [email protected] Unpin `camera_android` and remove its only usage (flutter/flutter#150017)
2024-06-10 [email protected] Fixes a bug where NavigatorState.pop does not consider any possible sâ�¦ (flutter/flutter#150014)
2024-06-10 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reland: [CupertinoActionSheet] Match colors to native (#149568) (#150015)" (flutter/flutter#150021)
2024-06-10 [email protected] Reland: [CupertinoActionSheet] Match colors to native (#149568) (flutter/flutter#150015)
2024-06-10 [email protected] Temporarily run Mac_arm64 framework_tests_misc on only Mac-13 (flutter/flutter#150009)
2024-06-10 [email protected] Fixes TextField hinttext in a11y_assessment (flutter/flutter#150007)
2024-06-10 [email protected] Use const bool.fromEnvironment("dart.tool.dart2wasm") to detect dart2wasm (flutter/flutter#149996)
2024-06-10 [email protected] Roll Packages from 8a2c4e4 to e95fe4a (3 revisions) (flutter/flutter#149997)
2024-06-10 [email protected] [web] Notify engine of handled PointerScrollEvents. (flutter/flutter#145500)
2024-06-10 [email protected] Cut no-longer-accurate microtask reference in finalizeTree doc (flutter/flutter#149941)
2024-06-10 [email protected] Update hasTrailingSpaces (flutter/flutter#149698)
2024-06-10 [email protected] [web] Change `--web-renderer` default from `auto` to `canvaskit` (flutter/flutter#149773)
2024-06-10 [email protected] Retain the toString method for subclasses of Key in profile/release mode (flutter/flutter#149926)
2024-06-10 [email protected] Remove package:platform from issue template (flutter/flutter#149995)
2024-06-10 [email protected] Revert "[CupertinoActionSheet] Match colors to native (#149568)" (flutter/flutter#149998)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This was referenced Jun 14, 2024
Closed
Closed
@mdebbar mdebbar deleted the renderer_default_canvaskit branch June 21, 2024 15:13
@blendthink blendthink mentioned this pull request Jul 7, 2024
Merged
@ditman ditman mentioned this pull request Jul 9, 2024
Closed
sfshaza2 pushed a commit to flutter/website that referenced this pull request Aug 5, 2024
@mdebbar
[web] Change --web-renderer default from auto to canvaskit (#10722
125ba78 
)

Changes the documentation of the default renderer on web. The default
renderer is changing from `auto` to `canvaskit`.

The PR making the code changes:
flutter/flutter#149773
The issue: flutter/flutter#149826

## Presubmit checklist

- [x] This PR doesn’t contain automatically generated corrections
(Grammarly or similar).
- [x] This PR follows the [Google Developer Documentation Style
Guidelines](https://developers.google.com/style) — for example, it
doesn’t use _i.e._ or _e.g._, and it avoids _I_ and _we_ (first person).
- [x] This PR uses [semantic line
breaks](https://github.com/dart-lang/site-shared/blob/main/doc/writing-for-dart-and-flutter-websites.md#semantic-line-breaks)
of 80 characters or fewer.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024
@engine-flutter-autoroll
ee10d2f [web] Change --web-renderer default from auto to `canvask…
c078ac6 
…it` (flutter/flutter#149773)
@fyzuladzwan fyzuladzwan mentioned this pull request Aug 7, 2024
Closed
@lstimacay lstimacay mentioned this pull request Nov 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eyebrowsoffire eyebrowsoffire eyebrowsoffire approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[web][breaking] Change --web-renderer default from auto to canvaskit

2 participants

@mdebbar @eyebrowsoffire