Swap crash reporting with unified analytics #148525

andrewkolos · 2024-05-17T00:25:07Z

(this is a remake of #147296; in hindsight I could have force-pushed there instead but 🤷)

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

andrewkolos · 2024-05-17T00:34:10Z

packages/flutter_tools/test/general.shard/crash_reporting_test.dart

+    fakeAnalytics = getInitializedFakeAnalyticsInstance(
+      fs: fs,
+      fakeFlutterVersion: FakeFlutterVersion(),
+    );


flutter/packages/flutter_tools/test/src/common.dart

Lines 314 to 319 in c1c7898

/// This method is required to fetch an instance of [FakeAnalytics]

/// because there is initialization logic that is required. An initial

/// instance will first be created and will let package:unified_analytics

/// know that the consent message has been shown. After confirming on the first

/// instance, then a second instance will be generated and returned. This second

/// instance will be cleared to send events.

seems to explain why a simple custom fake class wasn't used here.

christopherfujino

LGTM

…148525)

flutter/flutter@00425ef...adf279f 2024-05-18 [email protected] Fix template manifest test (flutter/flutter#148616) 2024-05-18 [email protected] Disable shuffling in the flutter_tools create_test suite (flutter/flutter#148619) 2024-05-18 [email protected] Move `Feedback` to widgets layer (flutter/flutter#148523) 2024-05-18 [email protected] Roll Flutter Engine from 93f1b5a146ed to 552a965b707b (4 revisions) (flutter/flutter#148595) 2024-05-18 [email protected] Swap crash reporting with unified analytics (flutter/flutter#148525) 2024-05-17 [email protected] Roll Flutter Engine from 5b3bf9a950b2 to 93f1b5a146ed (3 revisions) (flutter/flutter#148581) 2024-05-17 [email protected] Migrate the flutter/flutter wiki to docs/unsorted_wiki (flutter/flutter#148562) 2024-05-17 [email protected] Roll Flutter Engine from 17decdf12557 to 5b3bf9a950b2 (3 revisions) (flutter/flutter#148567) 2024-05-17 [email protected] Shift a test on MotoG4 to staging, add it on Mokey (flutter/flutter#148552) 2024-05-17 [email protected] Revert "`if` chains â�� `switch` expressions" (flutter/flutter#148556) 2024-05-17 [email protected] Roll Packages from 87a02e3 to ae4dd32 (9 revisions) (flutter/flutter#148555) 2024-05-17 [email protected] Roll Flutter Engine from 7d244ab0348a to 17decdf12557 (1 revision) (flutter/flutter#148549) 2024-05-17 [email protected] Roll Flutter Engine from a19d3722922d to 7d244ab0348a (4 revisions) (flutter/flutter#148546) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…148525)

andrewkolos added the tool Affects the "flutter" command-line tool. See also t: labels. label May 17, 2024

This comment was marked as off-topic.

Sign in to view

Use unified_analytics for crash reporting

18453e4

andrewkolos force-pushed the swap-crash-reporting-with-unified-analytics branch from ad4e009 to 18453e4 Compare May 17, 2024 00:26

andrewkolos commented May 17, 2024

View reviewed changes

andrewkolos marked this pull request as ready for review May 17, 2024 00:34

andrewkolos requested a review from christopherfujino May 17, 2024 00:34

christopherfujino approved these changes May 17, 2024

View reviewed changes

andrewkolos added the autosubmit Merge PR when tree becomes green via auto submit App label May 18, 2024

auto-submit bot merged commit ac6409b into flutter:master May 18, 2024

engine-flutter-autoroll mentioned this pull request May 18, 2024

Roll Flutter from 00425ef1be26 to adc9307bc521 (10 revisions) flutter/packages#6758

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 18, 2024

ac6409b Swap crash reporting with unified analytics (flutter/flutter#…

c1c06a4

…148525)

engine-flutter-autoroll mentioned this pull request May 18, 2024

Roll Flutter from 00425ef1be26 to f7012db828ea (11 revisions) flutter/packages#6759

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 18, 2024

ac6409b Swap crash reporting with unified analytics (flutter/flutter#…

685010a

…148525)

engine-flutter-autoroll mentioned this pull request May 19, 2024

Roll Flutter from 00425ef1be26 to adf279f3080f (13 revisions) flutter/packages#6760

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 19, 2024

ac6409b Swap crash reporting with unified analytics (flutter/flutter#…

01ea73e

…148525)

engine-flutter-autoroll mentioned this pull request May 19, 2024

Roll Flutter from 00425ef1be26 to adf279f3080f (13 revisions) flutter/packages#6761

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 19, 2024

ac6409b Swap crash reporting with unified analytics (flutter/flutter#…

cba58cd

…148525)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024

ac6409b Swap crash reporting with unified analytics (flutter/flutter#…

38b63dd

…148525)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Swap crash reporting with unified analytics #148525

Swap crash reporting with unified analytics #148525

Uh oh!

andrewkolos commented May 17, 2024 •

edited

Loading

Uh oh!

This comment was marked as off-topic.

andrewkolos May 17, 2024

Uh oh!

christopherfujino left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	/// This method is required to fetch an instance of [FakeAnalytics]
	/// because there is initialization logic that is required. An initial
	/// instance will first be created and will let package:unified_analytics
	/// know that the consent message has been shown. After confirming on the first
	/// instance, then a second instance will be generated and returned. This second
	/// instance will be cleared to send events.

Swap crash reporting with unified analytics #148525

Swap crash reporting with unified analytics #148525

Uh oh!

Conversation

andrewkolos commented May 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

This comment was marked as off-topic.

andrewkolos May 17, 2024

Choose a reason for hiding this comment

Uh oh!

christopherfujino left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

andrewkolos commented May 17, 2024 •

edited

Loading