Skip to content

Conversation

@derdilla
Copy link
Contributor

@derdilla derdilla commented May 9, 2024

Par of #130459. Adds tests all SliverFillRemaining examples.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: scrolling Viewports, list views, slivers, etc. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels May 9, 2024
@goderbauer goderbauer requested a review from gspencergoog May 10, 2024 21:05
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

Woohoo! Thanks!

@derdilla derdilla requested a review from gspencergoog May 13, 2024 06:58
@gspencergoog gspencergoog added the autosubmit Merge PR when tree becomes green via auto submit App label May 13, 2024
@auto-submit auto-submit bot merged commit 708fe97 into flutter:master May 13, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 13, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 13, 2024
auto-submit bot pushed a commit to flutter/packages that referenced this pull request May 13, 2024
flutter/flutter@1dfb46e...1255435

2024-05-13 [email protected] Native ios context menu (flutter/flutter#143002)
2024-05-13 [email protected] test sliver fill remaining examples (flutter/flutter#148041)
2024-05-13 [email protected] Roll Flutter Engine from fab7a7417888 to 0050bf9a8094 (1 revision) (flutter/flutter#148211)
2024-05-13 [email protected] Roll Flutter Engine from e568e5db9391 to fab7a7417888 (1 revision) (flutter/flutter#148207)
2024-05-13 [email protected] Roll Flutter Engine from 57e74a1b3860 to e568e5db9391 (2 revisions) (flutter/flutter#148204)
2024-05-13 [email protected] Roll Flutter Engine from 34fd28e8c7bd to 57e74a1b3860 (1 revision) (flutter/flutter#148196)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TecHaxter pushed a commit to TecHaxter/flutter_packages that referenced this pull request May 22, 2024
flutter/flutter@1dfb46e...1255435

2024-05-13 [email protected] Native ios context menu (flutter/flutter#143002)
2024-05-13 [email protected] test sliver fill remaining examples (flutter/flutter#148041)
2024-05-13 [email protected] Roll Flutter Engine from fab7a7417888 to 0050bf9a8094 (1 revision) (flutter/flutter#148211)
2024-05-13 [email protected] Roll Flutter Engine from e568e5db9391 to fab7a7417888 (1 revision) (flutter/flutter#148207)
2024-05-13 [email protected] Roll Flutter Engine from 57e74a1b3860 to e568e5db9391 (2 revisions) (flutter/flutter#148204)
2024-05-13 [email protected] Roll Flutter Engine from 34fd28e8c7bd to 57e74a1b3860 (1 revision) (flutter/flutter#148196)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants