Skip to content

Conversation

bleroux
Copy link
Contributor

@bleroux bleroux commented Feb 28, 2024

Description

This PR activates the M3 InkSparkle splash animation on Android + CanvasKit.
This is a reland for #138545 which was reverted due to a Flutter Gallery integration test failure.

The failure which lead to the revert was reproducible as described in #143075.
I'm no more able to reproduce this error locally.
The root issue was probably fixed in flutter/engine#49754.

Related Issue

Fixes #138487

Tests

Updates several existing tests.

@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Feb 28, 2024
@bleroux
Copy link
Contributor Author

bleroux commented Feb 29, 2024

Unfortunately, we're now back to the error message we got some months ago, see #138545 (comment)

Looks like this error was just hidden by the one fixed in flutter/engine#49754.
I will have a closer look to this error and comment soon.

@HansMuller HansMuller requested a review from Piinks March 1, 2024 00:00
@bleroux bleroux force-pushed the reland_activate_inksparkle_on_canvaskit branch from 521b726 to f459f57 Compare March 4, 2024 20:22
@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Mar 4, 2024
@bleroux bleroux force-pushed the reland_activate_inksparkle_on_canvaskit branch 2 times, most recently from 5c45dfa to cdc6713 Compare March 4, 2024 21:59
@github-actions github-actions bot removed the tool Affects the "flutter" command-line tool. See also t: labels. label Mar 4, 2024
@bleroux
Copy link
Contributor Author

bleroux commented Mar 5, 2024

I filed #144597 to make the ink_sparkle.frag file available to web tests.

@flutter-dashboard
Copy link

This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@bleroux bleroux force-pushed the reland_activate_inksparkle_on_canvaskit branch from cdc6713 to abac81b Compare April 28, 2024 10:31
@bleroux bleroux force-pushed the reland_activate_inksparkle_on_canvaskit branch 2 times, most recently from a8537ab to d9c1fd5 Compare April 28, 2024 16:24
@bleroux
Copy link
Contributor Author

bleroux commented May 23, 2024

Closing this PR for the moment because:

@bleroux bleroux closed this May 23, 2024
@bleroux bleroux deleted the reland_activate_inksparkle_on_canvaskit branch December 6, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: text input Entering text in a text field or keyboard related problems f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Activate InkSparkle on Canvaskit (Android only)

1 participant