Revert "Integrate testWidgets with leak tracking. (#138057)" #140502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d746007.
github-actions
bot
added
a: tests
mraleph
approved these changes
Dec 21, 2023
mraleph
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 21, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Dec 21, 2023
flutter/flutter@da0cd69...11def8e 2023-12-21 [email protected] Update README.md (flutter/flutter#140382) 2023-12-21 [email protected] Revert "Integrate testWidgets with leak tracking. (#138057)" (flutter/flutter#140502) 2023-12-21 [email protected] Integrate testWidgets with leak tracking. (flutter/flutter#138057) 2023-12-21 [email protected] Fix import pattern (flutter/flutter#140425) 2023-12-20 [email protected] Update job permissions (flutter/flutter#140476) 2023-12-20 [email protected] Roll pub packages (flutter/flutter#140472) 2023-12-20 [email protected] Remove outdated ignores from tool (flutter/flutter#140467) 2023-12-20 [email protected] Remove outdated ignores from framework (flutter/flutter#140465) 2023-12-20 [email protected] Reland `find.textRange.ofSubstring` changes (flutter/flutter#140469) 2023-12-20 [email protected] Part 1/n migration steps for kotlin migration (flutter/flutter#140452) 2023-12-20 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Make `TextSpan` hit testing precise." (flutter/flutter#140468) 2023-12-20 [email protected] [web] Re-enable test now that source of flakiness is fixed (flutter/flutter#140462) 2023-12-20 [email protected] Eliminate Cirrus build status badge (flutter/flutter#140461) 2023-12-20 [email protected] Move tests shifted to Pixel 7 from staging to prod (flutter/flutter#140438) 2023-12-20 [email protected] Roll Packages from be52ac8 to dc5b267 (5 revisions) (flutter/flutter#140450) 2023-12-20 [email protected] _TabBarViewState should not recreate page controller (flutter/flutter#135500) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
3 tasks
CoderDake
pushed a commit
to CoderDake/flutter
that referenced
this pull request
Dec 28, 2023
…lutter#140502) The PR is breaking the `flutter_test_performance` test and making the tree red.
3 tasks
auto-submit bot
added a commit
that referenced
this pull request
Jan 3, 2024
Reverts #140521 Initiated by: zanderso This change reverts the following previous change: Original Description: Original PR: #138057 Revert: #140502 Issue: https://ci.chromium.org/ui/p/flutter/builders/prod/Linux_android%20flutter_test_performance/12787/overview Exception: flutter test rendered unexpected output (1 bad lines) Explanation: leak tracker adds tear down even when there is no leak tracking, because at the moment of adding tear down it is unclear if leak tracking will be used for some tests. Fix: add enabling flag for leak tracker and make creation of tear down conditional. Prerequisites:
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR is breaking the
flutter_test_performancetest and making the tree red.