Skip to content

Conversation

matanlurey
Copy link
Contributor

Closes #132162.

I did a tiny bit of minor cleanup but didn't want to go 🍔 beyond the scope of this change. After it lands I'll update the Wiki.

Before

$ fl run \
  --local-engine-src-path=$ENGINE \
  --local-engine=android_debug_unopt_arm64

... would try to use host_debug_unopt (i.e. Rosetta).

After

$ fl run \
  --local-engine-src-path=$ENGINE \
  --local-engine=android_debug_unopt_arm64 \
  --local-engine-host=host_debug_unopt_arm64

... uses host_debug_unopt_arm64, as specified.


/cc @jonahwilliams @gaaclarke @zanderso

@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Aug 9, 2023
@matanlurey matanlurey force-pushed the tool-add-local-engine-host-argument branch from b8249f0 to d30596c Compare August 9, 2023 15:35
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@gaaclarke gaaclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't do a code review, but wanted to say this approach sounds good to me. It's mutually exclusive to your ideas about changing the default behavior and having better error messaging. We could chose to do those too if we wanted in the future.

@matanlurey
Copy link
Contributor Author

Didn't do a code review, but wanted to say this approach sounds good to me. It's mutually exclusive to your ideas about changing the default behavior and having better error messaging. We could chose to do those too if we wanted in the future.

Thanks! I appreciate you writing this!

@matanlurey matanlurey force-pushed the tool-add-local-engine-host-argument branch from 6ac1f9c to e36a805 Compare August 9, 2023 18:34
@github-actions github-actions bot added the a: desktop Running on desktop label Aug 9, 2023
@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 9, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 9, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Aug 9, 2023

auto label is removed for flutter/flutter/132180, due to - The status or check suite Windows framework_tests_libraries has failed. Please fix the issues identified (or deflake) before re-applying this label.

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 10, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 10, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 10, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: desktop Running on desktop tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flutter tool should use the correct architecture when "--local-engine" is specified
5 participants