Skip to content

Mark leak in text_form_field_test.dart. #130468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 13, 2023
Merged

Mark leak in text_form_field_test.dart. #130468

merged 2 commits into from
Jul 13, 2023

Conversation

polina-c
Copy link
Contributor

No description provided.

@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Jul 13, 2023
@polina-c polina-c mentioned this pull request Jul 13, 2023
Closed
@flutter-dashboard
Copy link

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #130468 at sha bf31143

@flutter-dashboard flutter-dashboard bot added the will affect goldens Changes to golden files label Jul 13, 2023
goderbauer
goderbauer approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@polina-c polina-c merged commit 8e80663 into flutter:master Jul 13, 2023
@polina-c polina-c deleted the text_form_field branch July 13, 2023 17:50
LouiseHsu pushed a commit to LouiseHsu/flutter that referenced this pull request Jul 13, 2023
@polina-c @LouiseHsu
Mark leak in text_form_field_test.dart. (flutter#130468)
ff41786
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023
@engine-flutter-autoroll
8e80663 Mark leak in text_form_field_test.dart. (flutter/flutter#130468)
a38ac50
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023
@engine-flutter-autoroll
8e80663 Mark leak in text_form_field_test.dart. (flutter/flutter#130468)
33cc76f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023
@engine-flutter-autoroll
8e80663 Mark leak in text_form_field_test.dart. (flutter/flutter#130468)
157195e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023
@engine-flutter-autoroll
8e80663 Mark leak in text_form_field_test.dart. (flutter/flutter#130468)
8ce17b5
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023
@engine-flutter-autoroll
8e80663 Mark leak in text_form_field_test.dart. (flutter/flutter#130468)
3b957cf
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023
@engine-flutter-autoroll
8e80663 Mark leak in text_form_field_test.dart. (flutter/flutter#130468)
98dde0d
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023
@engine-flutter-autoroll
8e80663 Mark leak in text_form_field_test.dart. (flutter/flutter#130468)
68ed3a1
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023
@engine-flutter-autoroll
8e80663 Mark leak in text_form_field_test.dart. (flutter/flutter#130468)
1d8a19f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 14, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2023
@engine-flutter-autoroll
8e80663 Mark leak in text_form_field_test.dart. (flutter/flutter#130468)
de6821f
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 15, 2023
@engine-flutter-autoroll
8e80663 Mark leak in text_form_field_test.dart. (flutter/flutter#130468)
752a754
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 15, 2023
@engine-flutter-autoroll
8e80663 Mark leak in text_form_field_test.dart. (flutter/flutter#130468)
6c32f9f
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 15, 2023
@engine-flutter-autoroll
8e80663 Mark leak in text_form_field_test.dart. (flutter/flutter#130468)
84382ce
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 16, 2023
@engine-flutter-autoroll
8e80663 Mark leak in text_form_field_test.dart. (flutter/flutter#130468)
6bda2a2
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 16, 2023
@engine-flutter-autoroll
8e80663 Mark leak in text_form_field_test.dart. (flutter/flutter#130468)
934e1a5
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
8e80663 Mark leak in text_form_field_test.dart. (flutter/flutter#130468)
0743186
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
8e80663 Mark leak in text_form_field_test.dart. (flutter/flutter#130468)
7105911
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
8e80663 Mark leak in text_form_field_test.dart. (flutter/flutter#130468)
d9a66de
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
8e80663 Mark leak in text_form_field_test.dart. (flutter/flutter#130468)
50ec1c1
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
8e80663 Mark leak in text_form_field_test.dart. (flutter/flutter#130468)
bc27b08
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
8e80663 Mark leak in text_form_field_test.dart. (flutter/flutter#130468)
3e35c1c
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
8e80663 Mark leak in text_form_field_test.dart. (flutter/flutter#130468)
e1116df
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2023
@engine-flutter-autoroll
8e80663 Mark leak in text_form_field_test.dart. (flutter/flutter#130468)
2658b94
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
8e80663 Mark leak in text_form_field_test.dart. (flutter/flutter#130468)
3f2a743
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
8e80663 Mark leak in text_form_field_test.dart. (flutter/flutter#130468)
ca11acd
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
8e80663 Mark leak in text_form_field_test.dart. (flutter/flutter#130468)
10cf750
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
8e80663 Mark leak in text_form_field_test.dart. (flutter/flutter#130468)
9ffd7ae
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
8e80663 Mark leak in text_form_field_test.dart. (flutter/flutter#130468)
50d5784
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
8e80663 Mark leak in text_form_field_test.dart. (flutter/flutter#130468)
374f237
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
8e80663 Mark leak in text_form_field_test.dart. (flutter/flutter#130468)
778aefb
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2023
@engine-flutter-autoroll
8e80663 Mark leak in text_form_field_test.dart. (flutter/flutter#130468)
4f84211
@polina-c polina-c mentioned this pull request Aug 28, 2023
Closed
@polina-c polina-c mentioned this pull request Oct 26, 2023
Closed
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees
No one assigned
Labels
a: text input Entering text in a text field or keyboard related problems f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. will affect goldens Changes to golden files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@polina-c @goderbauer