Skip to content

Add viewId to PointerEvents #128287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 7, 2023
Merged

Add viewId to PointerEvents #128287

merged 4 commits into from
Jun 7, 2023

Conversation

@goderbauer
Copy link
Member

@goderbauer goderbauer commented Jun 5, 2023

Follow-up to flutter/engine#42493.

@goderbauer goderbauer requested a review from dkwingsmt June 5, 2023 21:42
@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems f: gestures flutter/packages/flutter/gestures repository. framework flutter/packages/flutter repository. See also f: labels. labels Jun 5, 2023
@goderbauer
Copy link
Member Author

goderbauer commented Jun 5, 2023

@dkwingsmt With this in place, you should be able to rebase #127060 and implement correct view handling, I believe?

dkwingsmt
dkwingsmt approved these changes Jun 6, 2023
View reviewed changes
Copy link
Contributor

@dkwingsmt dkwingsmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/flutter/lib/src/gestures/events.dart Outdated
Copy link
Contributor

@dkwingsmt dkwingsmt Jun 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Move this to the top of parameter list to keep order consistent.

Copy link
Member Author

@goderbauer goderbauer Jun 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, also fixed for the other two instances where this went out of order.

packages/flutter/lib/src/gestures/hit_test.dart Outdated
Copy link
Contributor

@dkwingsmt dkwingsmt Jun 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we add something like this: To keep the current behavior, use 0 for viewId for the first view.

Copy link
Contributor

@dkwingsmt dkwingsmt Jun 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also to other copies of this method.

Copy link
Member Author

@goderbauer goderbauer Jun 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 7, 2023
@goderbauer goderbauer merged commit cff6733 into flutter:master Jun 7, 2023
@goderbauer goderbauer deleted the pointerViewId branch June 7, 2023 02:16
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2023
@engine-flutter-autoroll
cff6733 Add viewId to PointerEvents (flutter/flutter#128287)
085f048
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2023
@engine-flutter-autoroll
cff6733 Add viewId to PointerEvents (flutter/flutter#128287)
eb3f837
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 7, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 7, 2023
@engine-flutter-autoroll
cff6733 Add viewId to PointerEvents (flutter/flutter#128287)
9d85675
@goderbauer goderbauer mentioned this pull request Jun 7, 2023
Merged
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jun 7, 2023
@engine-flutter-autoroll
Roll Flutter from 0b74153 to 8a5c22e (46 revisions) (#4160)
e584280 
Roll Flutter from 0b74153 to 8a5c22e (46 revisions)

flutter/flutter@0b74153...8a5c22e

2023-06-07 [email protected] Super tiny MediaQuery doc update (flutter/flutter#127904)
2023-06-07 [email protected] Revert "Make inspector weakly referencing the inspected objects." (flutter/flutter#128436)
2023-06-07 [email protected] Update menu API docs to help developers migrate to m3 (flutter/flutter#128351)
2023-06-07 [email protected] [tools] allow explicitly specifying the JDK to use via a new config setting (flutter/flutter#128264)
2023-06-07 [email protected] Roll Flutter Engine from 6f9df0f988c1 to 59d5444cf06c (3 revisions) (flutter/flutter#128376)
2023-06-07 [email protected] Do not try to load main/default asset image if only higher-res variants exist (flutter/flutter#128143)
2023-06-07 [email protected] Addressed Ambiguity in transform.scale constructor docs (flutter/flutter#128182)
2023-06-07 [email protected] Super tiny fix of dead link (flutter/flutter#128160)
2023-06-07 [email protected] Refactor tests (flutter/flutter#128371)
2023-06-07 [email protected] Make inspector weakly referencing the inspected objects. (flutter/flutter#128095)
2023-06-07 [email protected] Add viewId to PointerEvents (flutter/flutter#128287)
2023-06-07 [email protected] Show error message in release mode when box is not laid out without losing performance (flutter/flutter#126302)
2023-06-06 [email protected] Roll Flutter Engine from ca499463ec2e to 6f9df0f988c1 (1 revision) (flutter/flutter#128363)
2023-06-06 [email protected] Update Draggable YouTube video link (flutter/flutter#128078)
2023-06-06 [email protected] Remove more rounding hacks from TextPainter (flutter/flutter#127826)
2023-06-06 [email protected] Roll Flutter Engine from 4571695f9e76 to ca499463ec2e (1 revision) (flutter/flutter#128356)
2023-06-06 [email protected] [Android] Update plugin and module templates to use Flutter constant for `compileSdkVersion` (flutter/flutter#128073)
2023-06-06 [email protected] handleSelectWord in MultiSelectableSelectionContainerDelegate should handle rects inside of rects (flutter/flutter#127478)
2023-06-06 [email protected] [flutter_tools] never tree shake 0x20 (space) font codepoints on web (flutter/flutter#128302)
2023-06-06 [email protected] Remove `textScaleFactor` dependent logic from `AppBar` (flutter/flutter#128112)
2023-06-06 [email protected] Roll Flutter Engine from b6d37f8f74ad to 4571695f9e76 (6 revisions) (flutter/flutter#128350)
2023-06-06 [email protected] Fix `Null check operator used on a null value` on TextField with contextMenuBuilder (flutter/flutter#128114)
2023-06-06 [email protected] Roll Packages from db4e5c2 to da72219 (10 revisions) (flutter/flutter#128348)
2023-06-06 [email protected] Updating cirrus docker image to ubuntu focal. (flutter/flutter#128291)
2023-06-06 [email protected] Adding example for migrating to navigation drawer (flutter/flutter#128295)
2023-06-06 [email protected] Roll Flutter Engine from 722aad83e5fe to b6d37f8f74ad (2 revisions) (flutter/flutter#128341)
2023-06-06 [email protected] Clean-up viewId casts in flutter_test (flutter/flutter#128256)
2023-06-06 [email protected] Update cherry-pick issue template to more uniform labels. (flutter/flutter#128333)
2023-06-06 [email protected] Use Material3 in the 2D viewport tests (flutter/flutter#128155)
2023-06-06 [email protected] Use a `show` over a `hide` for `test_api` exports (flutter/flutter#128298)
2023-06-06 [email protected] Roll Flutter Engine from aaa7574375a6 to 722aad83e5fe (1 revision) (flutter/flutter#128307)
2023-06-06 [email protected] Migration guide for moving from BottomNavigationBar to NavigationBar (flutter/flutter#128263)
2023-06-06 [email protected] [web] Use 'Uri' instead of 'dart:html' to extract pathname (flutter/flutter#127983)
2023-06-06 [email protected] Roll Flutter Engine from 2b353ae90731 to aaa7574375a6 (4 revisions) (flutter/flutter#128301)
2023-06-05 [email protected] Roll Flutter Engine from 220ece4d9faa to 2b353ae90731 (1 revision) (flutter/flutter#128293)
2023-06-05 49699333+dependabot[bot]@users.noreply.github.com Bump actions/labeler from 4.0.4 to 4.1.0 (flutter/flutter#128290)
2023-06-05 [email protected] Roll Flutter Engine from 7f12e3497428 to 220ece4d9faa (6 revisions) (flutter/flutter#128282)
2023-06-05 [email protected] [framework] attempt non-key solution (flutter/flutter#128273)
2023-06-05 [email protected] [labeler] Fix adding labels when name is directory (flutter/flutter#128243)
2023-06-05 [email protected] Remove scrollbar deprecations isAlwaysShown and hoverThickness (flutter/flutter#127351)
2023-06-05 [email protected] Fix update drag error that made NestedScrollView un-scrollable (flutter/flutter#127718)
2023-06-05 [email protected] Roll Flutter Engine from f9f72388a4da to 7f12e3497428 (4 revisions) (flutter/flutter#128271)
2023-06-05 [email protected] Migrate SemanticsBinding to onSemanticsActionEvent (flutter/flutter#128254)
2023-06-05 [email protected] Roll Flutter Engine from c838a1b05924 to f9f72388a4da (19 revisions) (flutter/flutter#128252)
2023-06-05 [email protected] [framework] force flexible space background to rebuild. (flutter/flutter#128138)
2023-06-05 [email protected] Roll Packages from 75085ed to db4e5c2 (4 revisions) (flutter/flutter#128246)
...
auto-submit bot pushed a commit that referenced this pull request Jun 8, 2023
@goderbauer
Fix PointerEventConverter doc (#128452)
1a61743 
Follow-up to #128287.
@HansMuller HansMuller mentioned this pull request Jun 9, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
@engine-flutter-autoroll
cff6733 Add viewId to PointerEvents (flutter/flutter#128287)
7d1056a
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
cff6733 Add viewId to PointerEvents (flutter/flutter#128287)
f7c6bba
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
cff6733 Add viewId to PointerEvents (flutter/flutter#128287)
df4e21c
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
cff6733 Add viewId to PointerEvents (flutter/flutter#128287)
c6be7a3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkwingsmt dkwingsmt dkwingsmt approved these changes

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App f: gestures flutter/packages/flutter/gestures repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@goderbauer @dkwingsmt