Skip to content

enable no_literal_bool_comparisons lint #126647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 16, 2023
Merged

enable no_literal_bool_comparisons lint #126647

merged 2 commits into from
May 16, 2023

Conversation

@goderbauer
Copy link
Member

@goderbauer goderbauer commented May 12, 2023

No description provided.

@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems f: cupertino flutter/packages/flutter/cupertino repository f: gestures flutter/packages/flutter/gestures repository. f: material design flutter/packages/flutter/material repository. f: routes Navigator, Router, and related APIs. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. platform-ios iOS applications specifically c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels May 12, 2023
@goderbauer
Copy link
Member Author

goderbauer commented May 12, 2023

Thank you @pq for the awesome quick fix!

christopherfujino
christopherfujino approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, cool!

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label May 16, 2023
@auto-submit auto-submit bot merged commit 5e1ba70 into flutter:master May 16, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
5e1ba70 enable no_literal_bool_comparisons lint (flutter/flutter#126647)
975289f
Hixie
Hixie reviewed May 16, 2023
View reviewed changes
packages/flutter/lib/src/foundation/assertions.dart
return true;
}());
final bool reportError = isInDebugMode || details.silent != true; // could be null
final bool reportError = isInDebugMode || !details.silent; // could be null
Copy link
Contributor

@Hixie Hixie May 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment is out of date

Copy link
Member Author

@goderbauer goderbauer May 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix: #126927

@goderbauer goderbauer deleted the enableBoolLint branch May 16, 2023 16:28
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
5e1ba70 enable no_literal_bool_comparisons lint (flutter/flutter#126647)
eb3030c
@goderbauer goderbauer mentioned this pull request May 16, 2023
Merged
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
5e1ba70 enable no_literal_bool_comparisons lint (flutter/flutter#126647)
9cfdb47
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
5e1ba70 enable no_literal_bool_comparisons lint (flutter/flutter#126647)
f4e4f0b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
5e1ba70 enable no_literal_bool_comparisons lint (flutter/flutter#126647)
9ffae1d
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
5e1ba70 enable no_literal_bool_comparisons lint (flutter/flutter#126647)
692ab49
auto-submit bot pushed a commit that referenced this pull request May 16, 2023
@goderbauer
Remove outdated comment (#126927)
1ca183d 
Follow-up to #126647 (comment).
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
5e1ba70 enable no_literal_bool_comparisons lint (flutter/flutter#126647)
41fa97f
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
5e1ba70 enable no_literal_bool_comparisons lint (flutter/flutter#126647)
9486bfa
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 16, 2023
@engine-flutter-autoroll
5e1ba70 enable no_literal_bool_comparisons lint (flutter/flutter#126647)
7e659d1
@goderbauer goderbauer mentioned this pull request May 17, 2023
Merged
auto-submit bot pushed a commit that referenced this pull request May 17, 2023
@goderbauer
Handle null return from WillPopCallback (#127039)
acbfb40 
Partial revert of #126647 to work around issue in google3.

See b/283046390
@HansMuller HansMuller mentioned this pull request May 19, 2023
Closed
CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request May 24, 2023
@goderbauer
enable no_literal_bool_comparisons lint (flutter#126647)
34e079e
CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request May 24, 2023
@goderbauer
Remove outdated comment (flutter#126927)
19820a7 
Follow-up to flutter#126647 (comment).
CaseyHillers pushed a commit to CaseyHillers/flutter that referenced this pull request May 24, 2023
@goderbauer
Handle null return from WillPopCallback (flutter#127039)
676a83b 
Partial revert of flutter#126647 to work around issue in google3.

See b/283046390
This was referenced May 25, 2023
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2023
@engine-flutter-autoroll
5e1ba70 enable no_literal_bool_comparisons lint (flutter/flutter#126647)
684cbdb
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
5e1ba70 enable no_literal_bool_comparisons lint (flutter/flutter#126647)
6407ce1
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
5e1ba70 enable no_literal_bool_comparisons lint (flutter/flutter#126647)
29962ec
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2023
@engine-flutter-autoroll
5e1ba70 enable no_literal_bool_comparisons lint (flutter/flutter#126647)
a130ba8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Hixie Hixie Hixie left review comments

+1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt. f: cupertino flutter/packages/flutter/cupertino repository f: gestures flutter/packages/flutter/gestures repository. f: material design flutter/packages/flutter/material repository. f: routes Navigator, Router, and related APIs. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@goderbauer @Hixie @christopherfujino