Skip to content

Conversation

hannah-hyj
Copy link
Member

issue:#111448

  1. Added a default max width as 640
  2. Added a drag handle, the user can also tap it to dismiss bottom sheet in a11y mode. Added drag handle color and size to bottom sheet theme.

571677645837_ pic

581677646439_ pic

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Mar 11, 2023
@hannah-hyj hannah-hyj mentioned this pull request Mar 11, 2023
8 tasks
Copy link
Member

@guidezpl guidezpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Quick comments about docs and relation with enableDrag

@gnprice
Copy link
Member

gnprice commented Mar 13, 2023

Everything LGTM now except what's covered in existing open threads:
#120855 (comment)
#122445 (comment)

I'll leave @HansMuller and @guidezpl to wrap those up and approve the PR when they think it's ready. Thanks for all your work on this!

@hannah-hyj hannah-hyj requested a review from guidezpl March 15, 2023 03:23
@hannah-hyj hannah-hyj requested a review from HansMuller March 16, 2023 04:18
Copy link
Member

@guidezpl guidezpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Just minor nits about formatting and docs

  _    ___ _____ __  __ 
 | |  / __|_   _|  \/  |
 | |_| (_ | | | | |\/| |
 |____\___| |_| |_|  |_|
                        

@hannah-hyj hannah-hyj added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 16, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 17, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 17, 2023

auto label is removed for flutter/flutter, pr: 122445, due to - The status or check suite Windows web_tool_tests_1_2 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@hannah-hyj hannah-hyj merged commit 9fc1fd1 into flutter:master Mar 19, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 19, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 19, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants