Revert "Reland: Removes single window assumptions from flutter_test"
#122193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
a: tests
CaseyHillers
added
the
autosubmit
|
For future archeologists: The failures that caused this revert were likely prompted by the accidental deletion of the |
Man, I really want to write a test/bot like we were talking about. Monitor that these test classes actually do match the signatures they're implementing... |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 9, 2023
…er_test` (#122060)" (flutter/flutter#122193)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 10, 2023
…er_test` (#122060)" (flutter/flutter#122193)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 10, 2023
…er_test` (#122060)" (flutter/flutter#122193)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 10, 2023
…er_test` (#122060)" (flutter/flutter#122193)
hannah-hyj
pushed a commit
to hannah-hyj/flutter
that referenced
this pull request
Mar 11, 2023
…flutter#122060)" (flutter#122193) Revert "Reland: Removes single window assumptions from `flutter_test`"
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 11, 2023
…er_test` (#122060)" (flutter/flutter#122193)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 12, 2023
…er_test` (#122060)" (flutter/flutter#122193)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
…er_test` (#122060)" (flutter/flutter#122193)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
…er_test` (#122060)" (flutter/flutter#122193)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #122060
See b/272195069
Google Testing shows this has triggered a large number of failures. I haven't finished running TGPs, but this landed right next to another large scale breakage. Pre-emptively reverting, and we can reland when the roll isn't backed up.