Skip to content

[M3] Update checkbox shape value #120976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 20, 2023
Merged

[M3] Update checkbox shape value #120976

merged 6 commits into from
Feb 20, 2023

Conversation

esouthren
Copy link
Contributor

Fixes #120906.

Checkbox spec defines shape as md.sys.shape.corner.full, but also with a border radius of 2.0.

In Flutter we map md.sys.shape.corner.full as StadiumBorder(), which by design does not have a overridable border radius.

So, I've modified the M3 defaults to use a RoundedRectangleBorder with a container.shape token value of 2.0.

The visual difference is:

Before After
Screenshot 2023-02-17 12 44 42 PM Screenshot 2023-02-17 12 43 56 PM

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Feb 17, 2023
@esouthren esouthren requested a review from guidezpl February 17, 2023 14:12
@esouthren esouthren marked this pull request as ready for review February 17, 2023 14:12
guidezpl
guidezpl requested changes Feb 17, 2023
View reviewed changes
@esouthren esouthren requested a review from guidezpl February 17, 2023 15:31
guidezpl
guidezpl approved these changes Feb 20, 2023
View reviewed changes
Copy link
Member

@guidezpl guidezpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

  _    ___ _____ __  __ 
 | |  / __|_   _|  \/  |
 | |_| (_ | | | | |\/| |
 |____\___| |_| |_|  |_|

@esouthren esouthren merged commit ae8d051 into flutter:master Feb 20, 2023
@esouthren esouthren deleted the cbox_shape branch February 20, 2023 11:38
@esouthren esouthren mentioned this pull request Feb 20, 2023
Merged
This was referenced Feb 20, 2023
Merged
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 20, 2023
@engine-flutter-autoroll
ae8d05184 [M3] Update checkbox shape value (flutter/flutter#120976)
667a212
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 20, 2023
@engine-flutter-autoroll
ae8d051 [M3] Update checkbox shape value (flutter/flutter#120976)
3bff9f6
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Feb 20, 2023
@engine-flutter-autoroll
Roll Flutter from 33e4d21 to ae8d051 (6 revisions) (#3229)
6f1b1e8 
* fc8b7c7 4434f3a43 Roll Fuchsia Mac SDK from HtmcMFg6ZlyRkcNsB... to 7FGKB187AdG0SCban... (flutter/engine#39756) (flutter/flutter#121067)

* d54d3b4 d00cc4b04 Roll Fuchsia Linux SDK from 7rgqQxifQPjH_2zXB... to 0RfFdaUCok_sFfUN1... (flutter/engine#39758) (flutter/flutter#121068)

* c71e479 cf85927ff Rename WindowPadding to ViewPadding (flutter/engine#39737) (flutter/flutter#121069)

* cc9b198 780279109 [Impeller] Implement invert colors flag. (flutter/engine#39729) (flutter/flutter#121074)

* 8d305b6 5d61f352c Roll Fuchsia Mac SDK from 7FGKB187AdG0SCban... to sXPr06r252ZU681Fi... (flutter/engine#39760) (flutter/flutter#121085)

* ae8d051 [M3] Update checkbox shape value (flutter/flutter#120976)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 21, 2023
@engine-flutter-autoroll
ae8d05184 [M3] Update checkbox shape value (flutter/flutter#120976)
56733cc
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 21, 2023
@engine-flutter-autoroll
ae8d05184 [M3] Update checkbox shape value (flutter/flutter#120976)
a0a04f4
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 21, 2023
@engine-flutter-autoroll
ae8d05184 [M3] Update checkbox shape value (flutter/flutter#120976)
0ea0fba
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 21, 2023
@engine-flutter-autoroll
ae8d05184 [M3] Update checkbox shape value (flutter/flutter#120976)
eef9775
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 21, 2023
@engine-flutter-autoroll
ae8d05184 [M3] Update checkbox shape value (flutter/flutter#120976)
99ed2b7
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 22, 2023
@engine-flutter-autoroll
ae8d05184 [M3] Update checkbox shape value (flutter/flutter#120976)
67fdf9b
@HansMuller HansMuller mentioned this pull request Mar 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
ae8d051 [M3] Update checkbox shape value (flutter/flutter#120976)
7f4951c
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
ae8d051 [M3] Update checkbox shape value (flutter/flutter#120976)
ada639b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guidezpl guidezpl guidezpl approved these changes

Assignees
No one assigned
Labels
c: contributor-productivity Team-specific productivity, code health, technical debt. f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[M3] Checkbox needs updated border radius value
2 participants
@esouthren @guidezpl