Skip to content

Reland Button padding M3 #119656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 22, 2023
Merged

Reland Button padding M3 #119656

merged 1 commit into from
Feb 22, 2023

Conversation

@CaseyHillers
Copy link
Contributor

@CaseyHillers CaseyHillers commented Jan 31, 2023 •
edited
Loading

Reverts #119597

I'll land this when the LSC tooling is ready, and the Flutter roll is up to date.

@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Jan 31, 2023
esouthren
esouthren approved these changes Feb 1, 2023
View reviewed changes
Copy link
Contributor

@esouthren esouthren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

guidezpl
guidezpl approved these changes Feb 1, 2023
View reviewed changes
Copy link
Member

@guidezpl guidezpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

  _    ___ _____ __  __ 
 | |  / __|_   _|  \/  |
 | |_| (_ | | | | |\/| |
 |____\___| |_| |_|  |_|

@CaseyHillers CaseyHillers force-pushed the revert-119597-revert-119498-button_reland branch from 9c3400c to d6723b9 Compare February 17, 2023 21:26
@CaseyHillers
Copy link
Contributor Author

CaseyHillers commented Feb 22, 2023

@XilaiZhang this is the first LSSC. Can you merge it in when you're ready?

@XilaiZhang
Copy link
Contributor

XilaiZhang commented Feb 22, 2023

Casey built a LSSC tool yesterday, we will merge in this PR today

@XilaiZhang XilaiZhang added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 22, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 22, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Feb 22, 2023

auto label is removed for flutter/flutter, pr: 119656, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@XilaiZhang
Copy link
Contributor

XilaiZhang commented Feb 22, 2023

will squash and merge

@XilaiZhang XilaiZhang merged commit 9241426 into master Feb 22, 2023
@XilaiZhang XilaiZhang deleted the revert-119597-revert-119498-button_reland branch February 22, 2023 21:51
@esouthren esouthren mentioned this pull request Feb 23, 2023
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2023
@engine-flutter-autoroll
9241426 Revert "Revert "[Re-land#2] Button padding M3 (#119498)" (#11…
f42e9d4 
…9597)" (flutter/flutter#119656)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2023
@engine-flutter-autoroll
9241426 Revert "Revert "[Re-land#2] Button padding M3 (#119498)" (#11…
b45030f 
…9597)" (flutter/flutter#119656)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 23, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2023
@engine-flutter-autoroll
9241426 Revert "Revert "[Re-land#2] Button padding M3 (#119498)" (#11…
c74d4f1 
…9597)" (flutter/flutter#119656)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
9241426 Revert "Revert "[Re-land#2] Button padding M3 (#119498)" (#11…
e53fe70 
…9597)" (flutter/flutter#119656)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
9241426 Revert "Revert "[Re-land#2] Button padding M3 (#119498)" (#11…
166bfd9 
…9597)" (flutter/flutter#119656)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
9241426 Revert "Revert "[Re-land#2] Button padding M3 (#119498)" (#11…
542aefd 
…9597)" (flutter/flutter#119656)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
9241426 Revert "Revert "[Re-land#2] Button padding M3 (#119498)" (#11…
e56c94f 
…9597)" (flutter/flutter#119656)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 24, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
9241426 Revert "Revert "[Re-land#2] Button padding M3 (#119498)" (#11…
89c5736 
…9597)" (flutter/flutter#119656)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 24, 2023
@engine-flutter-autoroll
9241426 Revert "Revert "[Re-land#2] Button padding M3 (#119498)" (#11…
b5f00e8 
…9597)" (flutter/flutter#119656)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2023
@engine-flutter-autoroll
9241426 Revert "Revert "[Re-land#2] Button padding M3 (#119498)" (#11…
970e094 
…9597)" (flutter/flutter#119656)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 25, 2023
@engine-flutter-autoroll
9241426 Revert "Revert "[Re-land#2] Button padding M3 (#119498)" (#11…
38c729e 
…9597)" (flutter/flutter#119656)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2023
@engine-flutter-autoroll
9241426 Revert "Revert "[Re-land#2] Button padding M3 (#119498)" (#11…
a992824 
…9597)" (flutter/flutter#119656)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2023
@engine-flutter-autoroll
9241426 Revert "Revert "[Re-land#2] Button padding M3 (#119498)" (#11…
5893c4f 
…9597)" (flutter/flutter#119656)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 26, 2023
@engine-flutter-autoroll
9241426 Revert "Revert "[Re-land#2] Button padding M3 (#119498)" (#11…
3c1462c 
…9597)" (flutter/flutter#119656)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
9241426 Revert "Revert "[Re-land#2] Button padding M3 (#119498)" (#11…
dae150b 
…9597)" (flutter/flutter#119656)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
9241426 Revert "Revert "[Re-land#2] Button padding M3 (#119498)" (#11…
40980a0 
…9597)" (flutter/flutter#119656)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
9241426 Revert "Revert "[Re-land#2] Button padding M3 (#119498)" (#11…
98f7dae 
…9597)" (flutter/flutter#119656)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
9241426 Revert "Revert "[Re-land#2] Button padding M3 (#119498)" (#11…
3581f5c 
…9597)" (flutter/flutter#119656)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
9241426 Revert "Revert "[Re-land#2] Button padding M3 (#119498)" (#11…
70e54c4 
…9597)" (flutter/flutter#119656)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
9241426 Revert "Revert "[Re-land#2] Button padding M3 (#119498)" (#11…
28b92fe 
…9597)" (flutter/flutter#119656)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 27, 2023
@engine-flutter-autoroll
9241426 Revert "Revert "[Re-land#2] Button padding M3 (#119498)" (#11…
f8758a8 
…9597)" (flutter/flutter#119656)
@HansMuller HansMuller mentioned this pull request Mar 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
9241426 Revert "Revert "[Re-land#2] Button padding M3 (#119498)" (#11…
8b4113f 
…9597)" (flutter/flutter#119656)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
9241426 Revert "Revert "[Re-land#2] Button padding M3 (#119498)" (#11…
e76b476 
…9597)" (flutter/flutter#119656)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guidezpl guidezpl guidezpl approved these changes

+1 more reviewer

@esouthren esouthren esouthren approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@XilaiZhang XilaiZhang

Labels

a: text input Entering text in a text field or keyboard related problems c: contributor-productivity Team-specific productivity, code health, technical debt. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@CaseyHillers @XilaiZhang @guidezpl @esouthren