Skip to content

Add todo for linux defines test. #119035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 24, 2023
Merged

Add todo for linux defines test. #119035

merged 2 commits into from
Jan 24, 2023

Conversation

@ricardoamador
Copy link
Contributor

@ricardoamador ricardoamador commented Jan 24, 2023 •
edited
Loading

Unblock the tree and add a todo message to fix android defines in dashboard.

Annotates the work that needs to be done for emulator tests that need to run on Linux only bots.
#119026

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

christopherfujino
christopherfujino approved these changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman
Copy link
Member

jmagman commented Jan 24, 2023

@ricardoamador for future reference, for the sake of a paper trail it is useful to refer to the issue in question #119026 in your description so this PR shows up as a reference in that issue.

@ricardoamador
Copy link
Contributor Author

@jmagman will do. Thank you.

@ricardoamador ricardoamador added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 24, 2023
@ricardoamador ricardoamador merged commit 84071aa into flutter:master Jan 24, 2023
This was referenced Jan 24, 2023
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 24, 2023
@engine-flutter-autoroll
84071aa Add todo for linux defines test. (flutter/flutter#119035)
c3fb26a
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jan 24, 2023
@engine-flutter-autoroll
84071aa Add todo for linux defines test. (flutter/flutter#119035)
035aaa2
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jan 24, 2023
@engine-flutter-autoroll
Roll Flutter from bd7bee0 to c35efda (24 revisions) (#3085)
a095576 
* 3bf7960 [web] Fix paths fetched by flutter.js (flutter/flutter#118684)

* e71e8da 76998e529 Roll Fuchsia Linux SDK from f613tOkDB282hW2tA... to GLRbnjiO5SbZKX-Us... (flutter/engine#39067) (flutter/flutter#119009)

* 71a4256 Revert "[Re-land] Button padding m3 (#118640)" (flutter/flutter#118962)

* 90ffb1c 94fc0728f Roll Dart SDK from c52810968747 to 107a1280a61f (1 revision) (flutter/engine#39069) (flutter/flutter#119010)

* 224e6aa Remove unnecessary null checks in flutter/gestures (flutter/flutter#118926)

* 6cd4945 Remove unnecessary null checks in flutter_web_plugins (flutter/flutter#118862)

* a63e19b Remove unnecessary null checks in flutter_localizations (flutter/flutter#118863)

* 19dfde6 Remove unnecessary null checks in `flutter/{foundation,services,physics}` (flutter/flutter#118910)

* 392dffe Update the Linux Android defines test to use dimensions when selecting a build bot (flutter/flutter#118930)

* 5e50ed9 Test Utf8FromUtf16 (flutter/flutter#118647)

* edb571e Update README.md (flutter/flutter#118803)

* 38630b6 Remove unnecessary null checks in `flutter_tool` (flutter/flutter#118857)

* 332aed9 Revert "Update the Linux Android defines test to use dimensions when selecting a build bot (#118930)" (flutter/flutter#119023)

* 84071aa Add todo for linux defines test. (flutter/flutter#119035)

* e8b7f4b [examples] Fix typo in `refresh_indicator` example (flutter/flutter#119000)

* df44208 Remove ThemeData.buttonColor references (flutter/flutter#118658)

* 6548616 Remove animated_complex_opacity_perf_macos__e2e_summary bringup (flutter/flutter#118916)

* 59767e5 Remove unnecessary null checks in `flutter/material` (flutter/flutter#119022)

* 1906ce5 7d3233d26 [web] Build multiple CanvasKit variants (using toolchain_args) (flutter/engine#38448) (flutter/flutter#119021)

* 720bea0 Remove unnecessary null checks in `flutter/widgets` (flutter/flutter#119028)

* 0de8bef Remove unnecessary null checks in flutter/cupertino (flutter/flutter#119020)

* 2e8dd9d Run integration_ui_test_test_macos in prod (flutter/flutter#118919)

* 64b4c69 roll pub deps and remove archive, crypto, typed_data from allow-list (flutter/flutter#119018)

* c35efda Remove superfluous words. (flutter/flutter#119008)
auto-submit bot pushed a commit to flutter/plugins that referenced this pull request Jan 24, 2023
@engine-flutter-autoroll
Roll Flutter from bd7bee0 to c35efda (24 revisions) (#7017)
80e36c2 
* 3bf7960 [web] Fix paths fetched by flutter.js (flutter/flutter#118684)

* e71e8da 76998e529 Roll Fuchsia Linux SDK from f613tOkDB282hW2tA... to GLRbnjiO5SbZKX-Us... (flutter/engine#39067) (flutter/flutter#119009)

* 71a4256 Revert "[Re-land] Button padding m3 (#118640)" (flutter/flutter#118962)

* 90ffb1c 94fc0728f Roll Dart SDK from c52810968747 to 107a1280a61f (1 revision) (flutter/engine#39069) (flutter/flutter#119010)

* 224e6aa Remove unnecessary null checks in flutter/gestures (flutter/flutter#118926)

* 6cd4945 Remove unnecessary null checks in flutter_web_plugins (flutter/flutter#118862)

* a63e19b Remove unnecessary null checks in flutter_localizations (flutter/flutter#118863)

* 19dfde6 Remove unnecessary null checks in `flutter/{foundation,services,physics}` (flutter/flutter#118910)

* 392dffe Update the Linux Android defines test to use dimensions when selecting a build bot (flutter/flutter#118930)

* 5e50ed9 Test Utf8FromUtf16 (flutter/flutter#118647)

* edb571e Update README.md (flutter/flutter#118803)

* 38630b6 Remove unnecessary null checks in `flutter_tool` (flutter/flutter#118857)

* 332aed9 Revert "Update the Linux Android defines test to use dimensions when selecting a build bot (#118930)" (flutter/flutter#119023)

* 84071aa Add todo for linux defines test. (flutter/flutter#119035)

* e8b7f4b [examples] Fix typo in `refresh_indicator` example (flutter/flutter#119000)

* df44208 Remove ThemeData.buttonColor references (flutter/flutter#118658)

* 6548616 Remove animated_complex_opacity_perf_macos__e2e_summary bringup (flutter/flutter#118916)

* 59767e5 Remove unnecessary null checks in `flutter/material` (flutter/flutter#119022)

* 1906ce5 7d3233d26 [web] Build multiple CanvasKit variants (using toolchain_args) (flutter/engine#38448) (flutter/flutter#119021)

* 720bea0 Remove unnecessary null checks in `flutter/widgets` (flutter/flutter#119028)

* 0de8bef Remove unnecessary null checks in flutter/cupertino (flutter/flutter#119020)

* 2e8dd9d Run integration_ui_test_test_macos in prod (flutter/flutter#118919)

* 64b4c69 roll pub deps and remove archive, crypto, typed_data from allow-list (flutter/flutter#119018)

* c35efda Remove superfluous words. (flutter/flutter#119008)
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
@engine-flutter-autoroll @mauricioluz
Roll Flutter from bd7bee0 to c35efda (24 revisions) (flutter#7017)
48869b3 
* 3bf7960 [web] Fix paths fetched by flutter.js (flutter/flutter#118684)

* e71e8da 76998e529 Roll Fuchsia Linux SDK from f613tOkDB282hW2tA... to GLRbnjiO5SbZKX-Us... (flutter/engine#39067) (flutter/flutter#119009)

* 71a4256 Revert "[Re-land] Button padding m3 (#118640)" (flutter/flutter#118962)

* 90ffb1c 94fc0728f Roll Dart SDK from c52810968747 to 107a1280a61f (1 revision) (flutter/engine#39069) (flutter/flutter#119010)

* 224e6aa Remove unnecessary null checks in flutter/gestures (flutter/flutter#118926)

* 6cd4945 Remove unnecessary null checks in flutter_web_plugins (flutter/flutter#118862)

* a63e19b Remove unnecessary null checks in flutter_localizations (flutter/flutter#118863)

* 19dfde6 Remove unnecessary null checks in `flutter/{foundation,services,physics}` (flutter/flutter#118910)

* 392dffe Update the Linux Android defines test to use dimensions when selecting a build bot (flutter/flutter#118930)

* 5e50ed9 Test Utf8FromUtf16 (flutter/flutter#118647)

* edb571e Update README.md (flutter/flutter#118803)

* 38630b6 Remove unnecessary null checks in `flutter_tool` (flutter/flutter#118857)

* 332aed9 Revert "Update the Linux Android defines test to use dimensions when selecting a build bot (#118930)" (flutter/flutter#119023)

* 84071aa Add todo for linux defines test. (flutter/flutter#119035)

* e8b7f4b [examples] Fix typo in `refresh_indicator` example (flutter/flutter#119000)

* df44208 Remove ThemeData.buttonColor references (flutter/flutter#118658)

* 6548616 Remove animated_complex_opacity_perf_macos__e2e_summary bringup (flutter/flutter#118916)

* 59767e5 Remove unnecessary null checks in `flutter/material` (flutter/flutter#119022)

* 1906ce5 7d3233d26 [web] Build multiple CanvasKit variants (using toolchain_args) (flutter/engine#38448) (flutter/flutter#119021)

* 720bea0 Remove unnecessary null checks in `flutter/widgets` (flutter/flutter#119028)

* 0de8bef Remove unnecessary null checks in flutter/cupertino (flutter/flutter#119020)

* 2e8dd9d Run integration_ui_test_test_macos in prod (flutter/flutter#118919)

* 64b4c69 roll pub deps and remove archive, crypto, typed_data from allow-list (flutter/flutter#119018)

* c35efda Remove superfluous words. (flutter/flutter#119008)
@ricardoamador ricardoamador deleted the linux_defines_todo branch September 25, 2023 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@keyonghan keyonghan Awaiting requested review from keyonghan

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ricardoamador @jmagman @christopherfujino