Skip to content

Fixes Text contrast test rect check #112492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 27, 2022
Merged

Fixes Text contrast test rect check #112492

merged 2 commits into from
Sep 27, 2022

Conversation

@chunhtai
Copy link
Contributor

@chunhtai chunhtai commented Sep 27, 2022

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Sep 27, 2022
jonahwilliams
jonahwilliams approved these changes Sep 27, 2022
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yikes, LGTM

Is landing this going to require a substantial g3fix for customer:money?

@chunhtai
Copy link
Contributor Author

chunhtai commented Sep 27, 2022

Yikes, LGTM

Is landing this going to require a substantial g3fix for customer:money?

I imagine so, the previous pr that introduce this already require a big effort on applying g3fix because the skip list keep changing everyday. but i have to fix this to unblock the other accessibility pr I am working on. It somehow exposes this problem

@chunhtai chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 27, 2022
@auto-submit auto-submit bot merged commit 86f3097 into flutter:master Sep 27, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2022
@engine-flutter-autoroll
86f3097 Fixes Text contrast test rect check (flutter/flutter#112492)
327cf39
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Sep 28, 2022
@engine-flutter-autoroll
86f3097 Fixes Text contrast test rect check (flutter/flutter#112492)
97a11cf
This was referenced Oct 4, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer Awaiting requested review from goderbauer

1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: tests "flutter test", flutter_test, or one of our tests autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chunhtai @jonahwilliams