Skip to content

Added ShapeBorder to expansionTile #112218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 3, 2022
Merged

Added ShapeBorder to expansionTile #112218

merged 2 commits into from
Oct 3, 2022

Conversation

DattatreyaReddy
Copy link
Contributor

@DattatreyaReddy DattatreyaReddy commented Sep 22, 2022 •
edited
Loading

copy of #108861

Adds [borderColor, collapsedBorderColor,border, collapsedBorder] shape, collapsedShape, clipBehaviour properties to Expansion Tile widget.

  • uses ShapeBorderTween to add expand/close animation

  • replaces _borderColorTween with _borderTween

  • Changes Container decoration of expansionTile from BoxDecoration to ShapeDecoration

List which issues are fixed by this PR.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Sep 22, 2022
@DattatreyaReddy
Copy link
Contributor Author

DattatreyaReddy commented Sep 22, 2022 •
edited
Loading

I would like to request a Review. @Piinks @bernaferrari

@keyonghan keyonghan mentioned this pull request Sep 22, 2022
Closed
gspencergoog
gspencergoog approved these changes Oct 3, 2022
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@gspencergoog
Copy link
Contributor

Thanks for the PR, seems like a good addition! In the next step, we'll get a second reviewer to check it out.

chunhtai
chunhtai approved these changes Oct 3, 2022
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some nits

@DattatreyaReddy DattatreyaReddy force-pushed the expansion_tile_border_shape branch from e03f946 to 0a2ffc2 Compare October 3, 2022 16:50
@chunhtai chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 3, 2022
@auto-submit auto-submit bot merged commit 3f22a07 into flutter:master Oct 3, 2022
@DattatreyaReddy DattatreyaReddy deleted the expansion_tile_border_shape branch October 3, 2022 17:55
This was referenced Oct 4, 2022
Merged
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 4, 2022
@engine-flutter-autoroll
3f22a07 Added ShapeBorder to expansionTile (flutter/flutter#112218)
13e94db
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Oct 4, 2022
@engine-flutter-autoroll
3f22a07 Added ShapeBorder to expansionTile (flutter/flutter#112218)
0cb5a0c
@TahaTesser TahaTesser mentioned this pull request Oct 13, 2023
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

@chunhtai chunhtai chunhtai approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Control border in ExpansionTile when expand children. Proposal to add decoration / border argument to ExpansionTile to control borders
3 participants
@DattatreyaReddy @gspencergoog @chunhtai