Skip to content

Conversation

@camsim99
Copy link
Contributor

@camsim99 camsim99 commented Sep 13, 2022

Bumps the Kotlin version of the multiple_flutter benchmark test to fix #109397 when trying to bump the path_provider Gradle version.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Sep 13, 2022
@camsim99 camsim99 marked this pull request as ready for review September 13, 2022 23:10
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Are we able to successfully roll the path_provider_android pin forward with this change?

@camsim99 camsim99 requested a review from keyonghan as a code owner September 15, 2022 22:01
@camsim99 camsim99 marked this pull request as draft September 20, 2022 16:14
@flutter-dashboard
Copy link

This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@camsim99 camsim99 marked this pull request as ready for review September 27, 2022 12:20
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I thought I had approved this!

@camsim99
Copy link
Contributor Author

camsim99 commented Sep 27, 2022

Are we able to successfully roll the path_provider_android pin forward with this change?

@stuartmorgan No worries! I tested out multiple_flutters with this change and the Gradle version change in path_provider locally, and it should be good to go. I'm going to follow this PR with bumping the rest of the integration test's Gradle and Kotlin versions where applicable to avoid this sort of issue in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

upgrade of package:path_provider_android broke flutter_engine_group_performance test

2 participants