Remove exclamation marks #107683

LongCatIsLooong · 2022-07-14T23:28:36Z

Remove some unnecessary !s in input decorator.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

justinmc

LGTM 👍

Thanks for cleaning this up!

limenote135 · 2022-09-28T12:26:37Z

@LongCatIsLooong @justinmc Is there a plan to hotfix this into the stable branch? Many users are facing this issue.

justinmc · 2022-09-28T16:55:12Z

@limenote135 What is the issue exactly? I want to make sure I understand which of the changes in this PR are unblocking you and in what way.

limenote135 · 2022-09-29T00:09:49Z

@justinmc This fixes issues: #111095, #112046, #111939, #97634.
After upgrading flutter 3.3 from 3.0, this error is reported significantly.

justinmc · 2022-09-29T18:07:34Z

Perfect, thank you!

@itsjustkevin Are we able to cherry-pick this fix?

limenote135 · 2022-10-06T14:34:31Z

@justinmc @itsjustkevin hi, how is it going?

DjordjeMancic97 · 2022-10-14T15:46:16Z

Hi I am experiencing issue which this PR is supposed to fix. When will this come to stable branch?

Null check operator used on a null value.
at .#0 State.widget (package:flutter/src/widgets/framework.dart:909:26)
at .#1 EditableTextState._value (package:flutter/src/widgets/editable_text.dart:2351:34)
at .#2 EditableTextState.updateEditingValue (package:flutter/src/widgets/editable_text.dart:2084:18)
at .#3 TextInput._handleTextInputInvocation (package:flutter/src/services/text_input.dart:1769:29)
at .#4 DefaultPlatformMenuDelegate._methodCallHandler (package:flutter/src/widgets/platform_menu_bar.dart:461:21)
at .#5 min (dart:math-patch/math_patch.dart:35:21)
at .#6 new Rect.fromPoints (dart:ui/geometry.dart:670:10)
at .#7 TypeTestingStub_MHi__Kua__X0_21928+0x2f
at .#8 DateTime._yearsFromSecondsSinceEpoch (dart:core-patch/date_patch.dart:377:3)
at .#9 SchedulerBinding.scheduleWarmUpFrame. (package:flutter/src/scheduler/binding.dart:899:16)
at .#10 PlatformDispatcher._unpackPointerDataPacket (dart:ui/platfor

LongCatIsLooong · 2022-10-15T00:27:32Z

@DjordjeMancic97 from the stacktrace this is not the same issue. It may have to do with the platform menu system. Could you open a new issue if there isn't one?

For those on the stable branch, the diff is one line: https://github.com/flutter/flutter/pull/107683/files#diff-f5f93c879cef9a102adbf148583de9f3d9a05f9678fdcad7bde106f62200bb34 so it's an option to patch this locally for the time being.

Co-authored-by: LongCatIsLooong <[email protected]> Co-authored-by: Casey Hillers <[email protected]>

remove exclamation marks

2ec4378

LongCatIsLooong requested a review from justinmc July 14, 2022 23:28

flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Jul 14, 2022

justinmc approved these changes Jul 15, 2022

View reviewed changes

LongCatIsLooong added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 15, 2022

auto-submit bot merged commit d728539 into flutter:master Jul 15, 2022

LongCatIsLooong deleted the remove-exclamation-marks branch July 15, 2022 18:55

This was referenced Jul 16, 2022

Roll Flutter from c4975d9be0e2 to 4f9528293f54 (16 revisions) flutter/plugins#6111

Merged

Roll Flutter from bbec650b64bc to 4f9528293f54 (21 revisions) flutter/packages#2327

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 16, 2022

d728539 Remove exclamation marks (flutter/flutter#107683)

0a3ae6e

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 16, 2022

d728539 Remove exclamation marks (flutter/flutter#107683)

6b3df34

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022

d728539 Remove exclamation marks (flutter/flutter#107683)

d7a49bc

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022

d728539 Remove exclamation marks (flutter/flutter#107683)

6bc6255

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022

d728539 Remove exclamation marks (flutter/flutter#107683)

71067e7

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022

d728539 Remove exclamation marks (flutter/flutter#107683)

bfed48d

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022

d728539 Remove exclamation marks (flutter/flutter#107683)

c447329

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022

d728539 Remove exclamation marks (flutter/flutter#107683)

12e9f66

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022

d728539 Remove exclamation marks (flutter/flutter#107683)

47fba04

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022

d728539 Remove exclamation marks (flutter/flutter#107683)

e16b264

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2022

d728539 Remove exclamation marks (flutter/flutter#107683)

87e5bd4

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 20, 2022

d728539 Remove exclamation marks (flutter/flutter#107683)

66b768e

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 20, 2022

d728539 Remove exclamation marks (flutter/flutter#107683)

3f51bc4

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 20, 2022

d728539 Remove exclamation marks (flutter/flutter#107683)

4ff8386

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 20, 2022

d728539 Remove exclamation marks (flutter/flutter#107683)

a0b3746

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 20, 2022

d728539 Remove exclamation marks (flutter/flutter#107683)

08cb7a9

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 20, 2022

d728539 Remove exclamation marks (flutter/flutter#107683)

d109438

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 20, 2022

d728539 Remove exclamation marks (flutter/flutter#107683)

7ef1e7b

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 21, 2022

d728539 Remove exclamation marks (flutter/flutter#107683)

0152522

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022

d728539 Remove exclamation marks (flutter/flutter#107683)

d879c25

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022

d728539 Remove exclamation marks (flutter/flutter#107683)

3f243d1

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022

d728539 Remove exclamation marks (flutter/flutter#107683)

d8766e9

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022

d728539 Remove exclamation marks (flutter/flutter#107683)

dd9524f

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022

d728539 Remove exclamation marks (flutter/flutter#107683)

48bce1a

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022

d728539 Remove exclamation marks (flutter/flutter#107683)

776f628

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022

d728539 Remove exclamation marks (flutter/flutter#107683)

e5a5659

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022

d728539 Remove exclamation marks (flutter/flutter#107683)

362e696

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022

d728539 Remove exclamation marks (flutter/flutter#107683)

6663e67

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2022

d728539 Remove exclamation marks (flutter/flutter#107683)

dadd6f0

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022

d728539 Remove exclamation marks (flutter/flutter#107683)

594805f

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022

d728539 Remove exclamation marks (flutter/flutter#107683)

d47cd46

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022

d728539 Remove exclamation marks (flutter/flutter#107683)

b87ffb8

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022

d728539 Remove exclamation marks (flutter/flutter#107683)

2cd950f

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022

d728539 Remove exclamation marks (flutter/flutter#107683)

38a8cf8

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2022

d728539 Remove exclamation marks (flutter/flutter#107683)

38882fc

camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022

Remove exclamation marks (flutter#107683)

053b4ba

wangjiejacques mentioned this pull request Sep 28, 2022

[Android][Samsung]: Tapping on special characters button from virtual keyboard triggers performPrivateCommand : onAppPrivateCommand @ EditableText: "_CastError (Null check operator used on a null value)" error. #97634

Closed

justinmc mentioned this pull request Oct 17, 2022

[CP] Null exception fix #113550

Closed

justinmc pushed a commit to justinmc/flutter that referenced this pull request Oct 17, 2022

Remove exclamation marks (flutter#107683)

4060e9f

justinmc mentioned this pull request Oct 17, 2022

[CP] Remove exclamation marks (#107683) #113553

Merged

CaseyHillers pushed a commit that referenced this pull request Oct 31, 2022

[CP] Remove exclamation marks (#107683) (#113553)

8536931

Co-authored-by: LongCatIsLooong <[email protected]> Co-authored-by: Casey Hillers <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Remove exclamation marks #107683

Remove exclamation marks #107683

Uh oh!

LongCatIsLooong commented Jul 14, 2022

Uh oh!

justinmc left a comment

Uh oh!

limenote135 commented Sep 28, 2022

Uh oh!

justinmc commented Sep 28, 2022

Uh oh!

limenote135 commented Sep 29, 2022

Uh oh!

justinmc commented Sep 29, 2022

Uh oh!

limenote135 commented Oct 6, 2022

Uh oh!

DjordjeMancic97 commented Oct 14, 2022

Uh oh!

LongCatIsLooong commented Oct 15, 2022

Uh oh!

Uh oh!

Remove exclamation marks #107683

Remove exclamation marks #107683

Uh oh!

Conversation

LongCatIsLooong commented Jul 14, 2022

Pre-launch Checklist

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

limenote135 commented Sep 28, 2022

Uh oh!

justinmc commented Sep 28, 2022

Uh oh!

limenote135 commented Sep 29, 2022

Uh oh!

justinmc commented Sep 29, 2022

Uh oh!

limenote135 commented Oct 6, 2022

Uh oh!

DjordjeMancic97 commented Oct 14, 2022

Uh oh!

LongCatIsLooong commented Oct 15, 2022

Uh oh!

Uh oh!