Skip to content

Fix SliverReorderableList item dispose #105097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2022
Merged

Fix SliverReorderableList item dispose #105097

merged 1 commit into from
Jun 9, 2022

Conversation

TahaTesser
Copy link
Member

fixes #105010

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Jun 1, 2022
@TahaTesser TahaTesser changed the title Fix ReorderableListView item dispose Fix SliverReorderableList item dispose Jun 1, 2022
@TahaTesser TahaTesser requested a review from chunhtai June 1, 2022 08:50
@goderbauer goderbauer requested a review from darrenaustin June 1, 2022 21:25
@HansMuller HansMuller removed the request for review from chunhtai June 2, 2022 15:51
@Piinks
Copy link
Contributor

Piinks commented Jun 8, 2022

(Triage) @darrenaustin can you take a look at this PR when you have a chance? Thanks!

darrenaustin
darrenaustin approved these changes Jun 9, 2022
View reviewed changes
Copy link
Contributor

@darrenaustin darrenaustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good fix to me. Thanks!

LGTM.

@fluttergithubbot fluttergithubbot merged commit f4604fe into flutter:master Jun 9, 2022
@TahaTesser TahaTesser deleted the fix_reorderable_list_item_dispose branch June 9, 2022 08:16
This was referenced Jun 9, 2022
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 9, 2022
@engine-flutter-autoroll
f4604fe Fix SliverReorderableList item dispose (flutter/flutter#105097
e02dd03 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 9, 2022
@engine-flutter-autoroll
f4604fe Fix SliverReorderableList item dispose (flutter/flutter#105097
9d696ea 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 9, 2022
@engine-flutter-autoroll
f4604fe Fix SliverReorderableList item dispose (flutter/flutter#105097
2beb162 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 9, 2022
@engine-flutter-autoroll
f4604fe Fix SliverReorderableList item dispose (flutter/flutter#105097
5318167 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 9, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jun 9, 2022
@engine-flutter-autoroll
f4604fe Fix SliverReorderableList item dispose (flutter/flutter#105097
56c90b3 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 9, 2022
@engine-flutter-autoroll
f4604fe Fix SliverReorderableList item dispose (flutter/flutter#105097
bf767fb 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 9, 2022
@engine-flutter-autoroll
f4604fe Fix SliverReorderableList item dispose (flutter/flutter#105097
d600355 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 9, 2022
@engine-flutter-autoroll
f4604fe Fix SliverReorderableList item dispose (flutter/flutter#105097
27180d3 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 9, 2022
@engine-flutter-autoroll
f4604fe Fix SliverReorderableList item dispose (flutter/flutter#105097
6700979 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 9, 2022
@engine-flutter-autoroll
f4604fe Fix SliverReorderableList item dispose (flutter/flutter#105097
10f1bd7 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 10, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 10, 2022
@engine-flutter-autoroll
f4604fe Fix SliverReorderableList item dispose (flutter/flutter#105097
ef72e9a 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 10, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 10, 2022
@engine-flutter-autoroll
f4604fe Fix SliverReorderableList item dispose (flutter/flutter#105097
e6182aa 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 10, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 10, 2022
@engine-flutter-autoroll
f4604fe Fix SliverReorderableList item dispose (flutter/flutter#105097
b8977c9 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 10, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 10, 2022
@engine-flutter-autoroll
f4604fe Fix SliverReorderableList item dispose (flutter/flutter#105097
cc367cc 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 10, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 10, 2022
@engine-flutter-autoroll
f4604fe Fix SliverReorderableList item dispose (flutter/flutter#105097
45cefbd 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 11, 2022
@engine-flutter-autoroll
f4604fe Fix SliverReorderableList item dispose (flutter/flutter#105097
af364ff 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 11, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 11, 2022
@engine-flutter-autoroll
f4604fe Fix SliverReorderableList item dispose (flutter/flutter#105097
33d67d5 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 12, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 12, 2022
@engine-flutter-autoroll
f4604fe Fix SliverReorderableList item dispose (flutter/flutter#105097
aee1d5d 
)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 12, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 12, 2022
@engine-flutter-autoroll
f4604fe Fix SliverReorderableList item dispose (flutter/flutter#105097
da2c6b1 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 13, 2022
@engine-flutter-autoroll
f4604fe Fix SliverReorderableList item dispose (flutter/flutter#105097
7b7994f 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 13, 2022
@engine-flutter-autoroll
f4604fe Fix SliverReorderableList item dispose (flutter/flutter#105097
2ddda35 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 14, 2022
@engine-flutter-autoroll
f4604fe Fix SliverReorderableList item dispose (flutter/flutter#105097
d146a70 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 14, 2022
@engine-flutter-autoroll
f4604fe Fix SliverReorderableList item dispose (flutter/flutter#105097
3f68c5a 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 14, 2022
@engine-flutter-autoroll
f4604fe Fix SliverReorderableList item dispose (flutter/flutter#105097
ff0305c 
)
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
@TahaTesser @camsim99
Fix SliverReorderableList item dispose (flutter#105097)
9456dd6
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
f4604fe Fix SliverReorderableList item dispose (flutter/flutter#105097
4ba97d0 
)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
f4604fe Fix SliverReorderableList item dispose (flutter/flutter#105097
fe1ea29 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@darrenaustin darrenaustin darrenaustin approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ReorderableListView in a Drawer: ListTile stuck during dragging
4 participants
@TahaTesser @Piinks @darrenaustin @fluttergithubbot