[Proposal] Reduce warnings in flutter.groovy file

[AbdeMohlbi]

Use case

right now (using flutter 3.19.6) when opening the android module in android studio the flutter.groovy file located inside ...\flutter\packages\flutter_tools\gradle\src\main\groovy\flutter.groovy needs some refactoring and cleaning because it has more then 70 warnings right now (some libraries are deprecated,some unused methods ...):
i couldn't upload the code cz github has a limit in the body length so it's here

Proposal

the updated version can be found here
note that i haven't change or delete any function or messed any kind of logic just cleaned a bit and did as same as here to get rid of buildDir deprecation(there is now 31 warnings )

[AbdeMohlbi]

also something strange is here (that ididn't touch )

private String resolveProperty(String name, String defaultValue) {
        if (localProperties == null) {
            localProperties = readPropertiesIfExist(new File(project.projectDir.parentFile, "local.properties"))
        }
        String result
        if (project.hasProperty(name)) {
            result = project.property(name)
        }
        if (result == null) {
            result = localProperties.getProperty(name)
        }
        if (result == null) {
            result = defaultValue
        }
        return result
    }

[AbdeMohlbi]

i've seen the flutter.groovy file inside the master branch and it has less errors and i've tried to make it better here(not tested yet i have some issues i'll try using the branch master and track it )

[huycozy]

Thanks for the proposal. This is number of warnings I see when opening that file on Android Studio:

• Flutter stable 3.19.6: 61 warnings
• Flutter master channel 3.22.0-14.0.pre.67: 24 warnings