-
Notifications
You must be signed in to change notification settings - Fork 29.5k
Closed
flutter/engine
#50796Labels
P1High-priority issues at the top of the work listHigh-priority issues at the top of the work listc: tech-debtTechnical debt, code quality, testing, etc.Technical debt, code quality, testing, etc.engineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.team-engineOwned by Engine teamOwned by Engine team
Description
See flutter/engine#50795.
A .gitignore file is useful to keeping the source tree and CI from being corrupted, but actually papers over the fact that it's easy to corrupt your local source directory. One off-the-wall suggestion with @zanderso and @dnfield was some sort tool/check that verifies that the source tree never contains certain files.
As a strawman, a .gitnogoaway:
**/android/**/GeneratedPluginRegistrant.java... which is failed if it exists on CI or locally.
There is an existing file that matches this pattern in our source tree, so we'll need to rename that file.
reidbaker
Metadata
Metadata
Assignees
Labels
P1High-priority issues at the top of the work listHigh-priority issues at the top of the work listc: tech-debtTechnical debt, code quality, testing, etc.Technical debt, code quality, testing, etc.engineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.team-engineOwned by Engine teamOwned by Engine team