[CP] Regression: ability to call nextFocus() on a node to focus its descendant

[tvolkert]

Issue Link

#134854

Commit Hash

e869144

Target

beta

PR Link

#137630

Changelog Description

FocusNode.nextFocus() can be used to focus a node that's a descendant of the node on which the method is called. This change fixes a regression whereby that functionality didn't work under certain circumstances.

Impacted Users

all Flutter devs

Impact Description

Applications that relied on the FocusNode.nextFocus() API would be at risk of having the focus traversal not working as expected. For example, the focus might not change, or it might focus the wrong node.

Workaround

No

Risk

low

Test Coverage

yes

Validation Steps

The cherrypick includes a new test case that validates the fix, so make sure all tests pass.

[itsjustkevin]

@chunhtai can you add the cp: approved label if this cherry-pick is good?

[itsjustkevin]

@tvolkert the pr_link section is for the cherry-pick PR.

Could you open a cherry-pick against the beta branch and update the issue with the new link?

[CaseyHillers]

This PR doesn't cleanly merge into the beta branch. My attempted merge resolution ran into test failures which prevented it from releasing in this weeks release.

[chunhtai]

What are the test failures?

[CaseyHillers]

See https://github.com/flutter/flutter/pull/137630/checks?check_run_id=18241483078. There's 6 checks failing

[XilaiZhang]

Hello! taking over the release oncall this week.
friendly ping @chunhtai, are we still interested in resolving the failing tests, and land this onto 3.16-candidate.0? Thank you!

[tvolkert]

I think @chunhtai is OOO starting today. @gspencergoog do you think you could take a look?

[gspencergoog]

Yeah, he might be kind of busy now. :-)

Ok, sure, I can take a look at the tests.

[gspencergoog]

When I check out flutter-3.16-candidate.0, the source git hash (e869144) is already incorporated into that branch. Are you sure we still need to cherry pick it there?