Update Android Studio version #8565
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pq
approved these changes
Oct 1, 2025
| } | ||
| // TODO(helin24): Delete this code (and potentially related code) if commenting out has no negative impact on Android editing. | ||
| // I believe this is to make gradle files show up nicely when a flutter project is opened, but this functionality already does not work | ||
| // and is not needed if we are recommending users edit Android files in a separate project window. |
There was a problem hiding this comment.
Thanks for inlining this context!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed code that seems to be related to making gradle files editable within a Flutter project window as the Android Studio code has changed. I will record some additional details in my internal notes.
There were also test compilation failures that suggested the annotations library wasn't required correctly. (see https://stackoverflow.com/questions/62066166/string-notnull-syntax-causes-notnull-not-applicable-to-type-use-in-in - thanks @pq). When I asked gemini about this, it suggested that we were compiling production source code twice for tests, because the test source sets included
srcas well. I guess it turns out that this isn't needed and the dependency on the production source code is implied; additionally, compiling the production source during test is bad because it can be compiled in the wrong environment. I think this is documentation that includes this info if we want to investigate further at a later time: https://docs.gradle.org/current/userguide/building_java_projects.html#sec:java_source_sets