Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@GaryQian
Copy link
Contributor

@GaryQian GaryQian commented Jun 20, 2019

This updates harfbuzz to the latest version.

Primarily motivated by flutter/flutter#28894, but as harfbuzz is 8 months old as of this PR, this update also picks up plenty of other misc fixes in harfbuzz itself.

@cbracken
Copy link
Member

For future archaeologists, please document the reason for needing the update in the commit message.

(I'm assuming this addresses a bug related to emoji size on iOS based on the linked issue)

@GaryQian GaryQian removed the Work in progress (WIP) Not ready (yet) for review! label Jun 21, 2019
@GaryQian GaryQian merged commit 780343a into flutter:master Jun 21, 2019
@cbracken
Copy link
Member

This appears to have broken the engine build

[1903/3575] CXX obj/third_party/harfbuzz/src/harfbuzz_sources.hb-common.o
FAILED: obj/third_party/harfbuzz/src/harfbuzz_sources.hb-common.o 
/b/s/w/ir/cache/goma/client/gomacc ../../buildtools/linux-x64/clang/bin/clang++ -MMD -MF obj/third_party/harfbuzz/src/harfbuzz_sources.hb-common.o.d -DHAVE_OT -DHAVE_ICU -DHAVE_ICU_BUILTIN -DUSE_OPENSSL=1 -DUSE_OPENSSL_CERTS=1 -DNO_TCMALLOC -DTOOLCHAIN_VERSION=bac220c15490dcf7b7d8136f75100bbc77e8d217 -DANDROID -DHAVE_SYS_UIO_H -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -D__compiler_offsetof=__builtin_offsetof -Dnan=__builtin_nan -D__GNU_SOURCE=1 -D_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS -D_LIBCPP_ENABLE_THREAD_SAFETY_ANNOTATIONS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -DUCHAR_TYPE=uint16_t -I../.. -Igen -I../../third_party/libcxx/include -I../../third_party/libcxxabi/include -I../../third_party/harfbuzz/src -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -I../../third_party/freetype2/include -fno-strict-aliasing -fPIC -pipe -fcolor-diagnostics -ffunction-sections -funwind-tables -fno-short-enums -nostdinc++ --target=aarch64-linux-android -Wall -Wextra -Wendif-labels -Werror -Wno-missing-field-initializers -Wno-unused-parameter -isystem../../third_party/android_tools/ndk/sources/android/support/include -isystem../../third_party/android_tools/ndk/sysroot/usr/include/aarch64-linux-android -D__ANDROID_API__=22 -fvisibility=hidden --sysroot=/b/s/w/ir/k/src/third_party/android_tools/ndk/sysroot -Wheader-hygiene -Wstring-conversion -Wthread-safety -Oz -fno-ident -fdata-sections -ffunction-sections -fomit-frame-pointer -g2 -Wno-missing-field-initializers -Wno-unused-variable -Wno-sign-compare -Wno-unused-function -Wno-unused-variable -fvisibility-inlines-hidden -std=c++17 -fno-rtti -fno-exceptions   -c ../../third_party/harfbuzz/src/hb-common.cc -o obj/third_party/harfbuzz/src/harfbuzz_sources.hb-common.o
../../third_party/harfbuzz/src/hb-common.cc:75:7: error: comparison of integers of different signs: 'size_t' (aka 'unsigned long') and 'long' [-Werror,-Wsign-compare]
      OPTION ("uniscribe-bug-compatible", uniscribe_bug_compatible);
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../third_party/harfbuzz/src/hb-common.cc:73:53: note: expanded from macro 'OPTION'
        if (0 == strncmp (c, name, p - c) && strlen (name) == p - c) do { u.opts.symbol = true; } while (0)
                                             ~~~~~~~~~~~~~ ^  ~~~~~
../../third_party/harfbuzz/src/hb-common.cc:76:7: error: comparison of integers of different signs: 'size_t' (aka 'unsigned long') and 'long' [-Werror,-Wsign-compare]
      OPTION ("aat", aat);
      ^~~~~~~~~~~~~~~~~~~
../../third_party/harfbuzz/src/hb-common.cc:73:53: note: expanded from macro 'OPTION'
        if (0 == strncmp (c, name, p - c) && strlen (name) == p - c) do { u.opts.symbol = true; } while (0)
                                             ~~~~~~~~~~~~~ ^  ~~~~~
2 errors generated.

GaryQian added a commit that referenced this pull request Jun 21, 2019
GaryQian added a commit that referenced this pull request Jun 21, 2019
GaryQian added a commit that referenced this pull request Jun 21, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 21, 2019
GaryQian added a commit that referenced this pull request Jun 21, 2019
GaryQian added a commit that referenced this pull request Jun 22, 2019
GaryQian added a commit that referenced this pull request Jun 22, 2019
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Jun 22, 2019
flutter/engine@a9a0b89...e32307e

git log a9a0b89..e32307e --no-merges --oneline
e32307e Revert "Update harfbuzz to 2.5.2 (#9406)" (flutter/engine#9429)
780343a Update harfbuzz to 2.5.2 (flutter/engine#9406)
3757f19 delegate checkInputConnectionProxy to the relevant platform view (flutter/engine#9426)
d9dfad3 Roll src/third_party/skia 8676929c0a13..893403fb3896 (6 commits) (flutter/engine#9421)
91e31dc Made the license check ignore the .vscode directory. (flutter/engine#9398)
24c3f51 Roll src/third_party/skia a1d26a807798..8676929c0a13 (9 commits) (flutter/engine#9416)
e33f83e Roll src/third_party/skia e3beb99f39f0..a1d26a807798 (1 commits) (flutter/engine#9411)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff ([email protected]), and stop
the roller if necessary.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 22, 2019
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Jun 22, 2019
flutter/engine@fa16bab...d004bcd

git log fa16bab..d004bcd --no-merges --oneline
d004bcd Revert "Reland Update harfbuzz to 2.5.2 (#9406)" (flutter/engine#9437)
264d6d5 Reland Update harfbuzz to 2.5.2 (flutter/engine#9406)
f638958 Ios unit tests choose engine (flutter/engine#9432)
8f20c1b Roll src/third_party/skia 893403fb3896..f3881b278e69 (9 commits) (flutter/engine#9434)
6d2d9c8 Resolves embedding log chattyness by gating verbose, debug, and info logs by level (#34876). (flutter/engine#9425)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff ([email protected]), and stop
the roller if necessary.
johnsonmh pushed a commit to johnsonmh/flutter that referenced this pull request Jul 30, 2019
flutter/engine@a9a0b89...e32307e

git log a9a0b89..e32307e --no-merges --oneline
e32307e Revert &flutter#34;Update harfbuzz to 2.5.2 (flutter#9406)&flutter#34; (flutter/engine#9429)
780343a Update harfbuzz to 2.5.2 (flutter/engine#9406)
3757f19 delegate checkInputConnectionProxy to the relevant platform view (flutter/engine#9426)
d9dfad3 Roll src/third_party/skia 8676929c0a13..893403fb3896 (6 commits) (flutter/engine#9421)
91e31dc Made the license check ignore the .vscode directory. (flutter/engine#9398)
24c3f51 Roll src/third_party/skia a1d26a807798..8676929c0a13 (9 commits) (flutter/engine#9416)
e33f83e Roll src/third_party/skia e3beb99f39f0..a1d26a807798 (1 commits) (flutter/engine#9411)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff ([email protected]), and stop
the roller if necessary.
johnsonmh pushed a commit to johnsonmh/flutter that referenced this pull request Jul 30, 2019
flutter/engine@fa16bab...d004bcd

git log fa16bab..d004bcd --no-merges --oneline
d004bcd Revert &flutter#34;Reland Update harfbuzz to 2.5.2 (flutter#9406)&flutter#34; (flutter/engine#9437)
264d6d5 Reland Update harfbuzz to 2.5.2 (flutter/engine#9406)
f638958 Ios unit tests choose engine (flutter/engine#9432)
8f20c1b Roll src/third_party/skia 893403fb3896..f3881b278e69 (9 commits) (flutter/engine#9434)
6d2d9c8 Resolves embedding log chattyness by gating verbose, debug, and info logs by level (flutter#34876). (flutter/engine#9425)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff ([email protected]), and stop
the roller if necessary.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants