This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
Update harfbuzz to 2.5.2 #9406
Merged
Merged
Update harfbuzz to 2.5.2 #9406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
For future archaeologists, please document the reason for needing the update in the commit message. (I'm assuming this addresses a bug related to emoji size on iOS based on the linked issue) |
Member
|
This appears to have broken the engine build |
GaryQian
added a commit
that referenced
this pull request
Jun 21, 2019
GaryQian
added a commit
that referenced
this pull request
Jun 21, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 21, 2019
GaryQian
added a commit
that referenced
this pull request
Jun 22, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Jun 22, 2019
flutter/engine@a9a0b89...e32307e git log a9a0b89..e32307e --no-merges --oneline e32307e Revert "Update harfbuzz to 2.5.2 (#9406)" (flutter/engine#9429) 780343a Update harfbuzz to 2.5.2 (flutter/engine#9406) 3757f19 delegate checkInputConnectionProxy to the relevant platform view (flutter/engine#9426) d9dfad3 Roll src/third_party/skia 8676929c0a13..893403fb3896 (6 commits) (flutter/engine#9421) 91e31dc Made the license check ignore the .vscode directory. (flutter/engine#9398) 24c3f51 Roll src/third_party/skia a1d26a807798..8676929c0a13 (9 commits) (flutter/engine#9416) e33f83e Roll src/third_party/skia e3beb99f39f0..a1d26a807798 (1 commits) (flutter/engine#9411) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 22, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Jun 22, 2019
flutter/engine@fa16bab...d004bcd git log fa16bab..d004bcd --no-merges --oneline d004bcd Revert "Reland Update harfbuzz to 2.5.2 (#9406)" (flutter/engine#9437) 264d6d5 Reland Update harfbuzz to 2.5.2 (flutter/engine#9406) f638958 Ios unit tests choose engine (flutter/engine#9432) 8f20c1b Roll src/third_party/skia 893403fb3896..f3881b278e69 (9 commits) (flutter/engine#9434) 6d2d9c8 Resolves embedding log chattyness by gating verbose, debug, and info logs by level (#34876). (flutter/engine#9425) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
johnsonmh
pushed a commit
to johnsonmh/flutter
that referenced
this pull request
Jul 30, 2019
flutter/engine@a9a0b89...e32307e git log a9a0b89..e32307e --no-merges --oneline e32307e Revert &flutter#34;Update harfbuzz to 2.5.2 (flutter#9406)&flutter#34; (flutter/engine#9429) 780343a Update harfbuzz to 2.5.2 (flutter/engine#9406) 3757f19 delegate checkInputConnectionProxy to the relevant platform view (flutter/engine#9426) d9dfad3 Roll src/third_party/skia 8676929c0a13..893403fb3896 (6 commits) (flutter/engine#9421) 91e31dc Made the license check ignore the .vscode directory. (flutter/engine#9398) 24c3f51 Roll src/third_party/skia a1d26a807798..8676929c0a13 (9 commits) (flutter/engine#9416) e33f83e Roll src/third_party/skia e3beb99f39f0..a1d26a807798 (1 commits) (flutter/engine#9411) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
johnsonmh
pushed a commit
to johnsonmh/flutter
that referenced
this pull request
Jul 30, 2019
flutter/engine@fa16bab...d004bcd git log fa16bab..d004bcd --no-merges --oneline d004bcd Revert &flutter#34;Reland Update harfbuzz to 2.5.2 (flutter#9406)&flutter#34; (flutter/engine#9437) 264d6d5 Reland Update harfbuzz to 2.5.2 (flutter/engine#9406) f638958 Ios unit tests choose engine (flutter/engine#9432) 8f20c1b Roll src/third_party/skia 893403fb3896..f3881b278e69 (9 commits) (flutter/engine#9434) 6d2d9c8 Resolves embedding log chattyness by gating verbose, debug, and info logs by level (flutter#34876). (flutter/engine#9425) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff ([email protected]), and stop the roller if necessary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates harfbuzz to the latest version.
Primarily motivated by flutter/flutter#28894, but as harfbuzz is 8 months old as of this PR, this update also picks up plenty of other misc fixes in harfbuzz itself.