This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add flush to canvas #8514
Closed
Add flush to canvas #8514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@Hixie : does the addition of |
This is required for a high-priority Google client. I've tested it locally and the ShaderWarmUp can now generate multiple shaders in one frame that were not possible before. The engine roll with this PR needs a manual fix on `_MulticastCanvas`
Contributor
Author
|
Superseded by flutter/flutter#30825 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required for a high-priority Google client. I've tested it
locally and the ShaderWarmUp can now generate multiple shaders in one
frame that were not possible before.
The engine roll with this PR needs a manual fix on
_MulticastCanvasRelated issue: flutter/flutter#813