This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Remove LayerBuilder and DefaultLayerBuilder #6256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This essentially reverts flutter#4197 as no one is (or soon will be) implementing an alternative LayerBuilder. Let's just put everything in SceneBuilder to reduce the YAGNI (you aren't gonna need it) smell. This will also make retained rendering API changes much easier.
chinmaygarde
approved these changes
Sep 14, 2018
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 14, 2018
flutter/engine@24d9460...b43b3e8 git log 24d9460..b43b3e8 --no-merges --oneline b43b3e8 Remove LayerBuilder and DefaultLayerBuilder (flutter/engine#6256) e817f2d Roll src/third_party/skia 7724d3f4949b..7b617a7fc85d (6 commits) (flutter/engine#6255) a0dff81 Update test and license scripts for Dart SDK 2.1.0 (flutter/engine#6254) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
liyuqian
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 16, 2018
flutter/engine@24d9460...b43b3e8 git log 24d9460..b43b3e8 --no-merges --oneline b43b3e8 Remove LayerBuilder and DefaultLayerBuilder (flutter/engine#6256) e817f2d Roll src/third_party/skia 7724d3f4949b..7b617a7fc85d (6 commits) (flutter/engine#6255) a0dff81 Update test and license scripts for Dart SDK 2.1.0 (flutter/engine#6254) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
amirh
pushed a commit
to amirh/engine
that referenced
this pull request
Sep 21, 2018
This essentially reverts flutter#4197 as no one is (or soon will be) implementing an alternative LayerBuilder. Let's just put everything in SceneBuilder to reduce the YAGNI (you aren't gonna need it) smell. This will also make retained rendering API changes much easier.
amirh
pushed a commit
to amirh/engine
that referenced
this pull request
Sep 21, 2018
This essentially reverts flutter#4197 as no one is (or soon will be) implementing an alternative LayerBuilder. Let's just put everything in SceneBuilder to reduce the YAGNI (you aren't gonna need it) smell. This will also make retained rendering API changes much easier.
xxrlzzz
reviewed
Feb 22, 2021
| return; | ||
| } | ||
| SkPoint offset = SkPoint::Make(dx, dy); | ||
| SkRect pictureRect = picture->picture()->cullRect(); |
Contributor
There was a problem hiding this comment.
I think this two lines of code is useless since line 205-207 was deleted in some commit.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This essentially reverts #4197
as no one is (or soon will be) implementing an alternative LayerBuilder.
Let's just put everything in SceneBuilder to reduce the YAGNI
(you aren't gonna need it) smell. This will also make retained rendering
API changes much easier.