This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Update live region to trigger on label change #6248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jonahwilliams
commented
Sep 13, 2018
jonahwilliams
commented
- Remove option to manually trigger change. This is unused in flutter and undocumented (and unsupported on iOS), so I am going to quietly deprecate and remove the feature.
jonahwilliams
requested review from
goderbauer and
yjbanov
and removed request for
goderbauer
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 14, 2018
flutter/engine@7a9b430...60bb5da git log 7a9b430..60bb5da --no-merges --oneline 60bb5da Reapply "Some cleanups enabled by removing support for Dart 1" (flutter/engine#6250) 272be27 update live region to trigger on label change, remove manual trigger (flutter/engine#6248) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Sep 14, 2018
flutter/engine@7a9b430...60bb5da git log 7a9b430..60bb5da --no-merges --oneline 60bb5da Reapply "Some cleanups enabled by removing support for Dart 1" (flutter/engine#6250) 272be27 update live region to trigger on label change, remove manual trigger (flutter/engine#6248) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
amirh
pushed a commit
to amirh/engine
that referenced
this pull request
Sep 21, 2018
amirh
pushed a commit
to amirh/engine
that referenced
this pull request
Sep 21, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.