This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix LibTxt/minikin text shifiting when breaking into multiple runs #6184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jason-simmons
approved these changes
Sep 6, 2018
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 6, 2018
flutter/engine@5f61056...a146862 git log 5f61056..a146862 --no-merges --oneline a146862 Roll src/third_party/skia 33d3d31a7e28..a9564d6dae1c (5 commits) (flutter/engine#6185) 058edef Fix LibTxt/minikin text shifiting when breaking into multiple runs (flutter/engine#6184) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 6, 2018
flutter/engine@5f61056...bd7593b git log 5f61056..bd7593b --no-merges --oneline bd7593b [fuchsia] Plumb root_surface_transformation in scene_update_context (flutter/engine#6187) 30c8da8 Pull $flutter_root:config into shell/engine/version:version (flutter/engine#6186) a146862 Roll src/third_party/skia 33d3d31a7e28..a9564d6dae1c (5 commits) (flutter/engine#6185) 058edef Fix LibTxt/minikin text shifiting when breaking into multiple runs (flutter/engine#6184) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 6, 2018
flutter/engine@5f61056...e70d0e1 git log 5f61056..e70d0e1 --no-merges --oneline e70d0e1 Always serialize fonts during skp capturing (flutter/engine#6160) bd7593b [fuchsia] Plumb root_surface_transformation in scene_update_context (flutter/engine#6187) 30c8da8 Pull $flutter_root:config into shell/engine/version:version (flutter/engine#6186) a146862 Roll src/third_party/skia 33d3d31a7e28..a9564d6dae1c (5 commits) (flutter/engine#6185) 058edef Fix LibTxt/minikin text shifiting when breaking into multiple runs (flutter/engine#6184) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 6, 2018
flutter/engine@5f61056...9b297b3 git log 5f61056..9b297b3 --no-merges --oneline 9b297b3 Roll src/third_party/skia a9564d6dae1c..106d04e907c1 (7 commits) (flutter/engine#6190) e70d0e1 Always serialize fonts during skp capturing (flutter/engine#6160) bd7593b [fuchsia] Plumb root_surface_transformation in scene_update_context (flutter/engine#6187) 30c8da8 Pull $flutter_root:config into shell/engine/version:version (flutter/engine#6186) a146862 Roll src/third_party/skia 33d3d31a7e28..a9564d6dae1c (5 commits) (flutter/engine#6185) 058edef Fix LibTxt/minikin text shifiting when breaking into multiple runs (flutter/engine#6184) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
GaryQian
pushed a commit
to flutter/goldens
that referenced
this pull request
Sep 6, 2018
GaryQian
added a commit
to flutter/goldens
that referenced
this pull request
Sep 6, 2018
GaryQian
added a commit
to GaryQian/flutter
that referenced
this pull request
Sep 6, 2018
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 7, 2018
flutter/engine@5f61056...f02fc8c git log 5f61056..f02fc8c --no-merges --oneline f02fc8c Dart SDK roll for 2018/09/06 (flutter/engine#6189) 58a1894 Update to latest clang (flutter/engine#6174) 9b297b3 Roll src/third_party/skia a9564d6dae1c..106d04e907c1 (7 commits) (flutter/engine#6190) e70d0e1 Always serialize fonts during skp capturing (flutter/engine#6160) bd7593b [fuchsia] Plumb root_surface_transformation in scene_update_context (flutter/engine#6187) 30c8da8 Pull $flutter_root:config into shell/engine/version:version (flutter/engine#6186) a146862 Roll src/third_party/skia 33d3d31a7e28..a9564d6dae1c (5 commits) (flutter/engine#6185) 058edef Fix LibTxt/minikin text shifiting when breaking into multiple runs (flutter/engine#6184) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 7, 2018
flutter/engine@5f61056...e164e83 git log 5f61056..e164e83 --no-merges --oneline e164e83 Reset the raster cache when the compositor context is created. (flutter/engine#6150) f02fc8c Dart SDK roll for 2018/09/06 (flutter/engine#6189) 58a1894 Update to latest clang (flutter/engine#6174) 9b297b3 Roll src/third_party/skia a9564d6dae1c..106d04e907c1 (7 commits) (flutter/engine#6190) e70d0e1 Always serialize fonts during skp capturing (flutter/engine#6160) bd7593b [fuchsia] Plumb root_surface_transformation in scene_update_context (flutter/engine#6187) 30c8da8 Pull $flutter_root:config into shell/engine/version:version (flutter/engine#6186) a146862 Roll src/third_party/skia 33d3d31a7e28..a9564d6dae1c (5 commits) (flutter/engine#6185) 058edef Fix LibTxt/minikin text shifiting when breaking into multiple runs (flutter/engine#6184) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
This was referenced Sep 7, 2018
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 7, 2018
flutter/engine@5f61056...b09563b git log 5f61056..b09563b --no-merges --oneline b09563b Roll src/third_party/skia 106d04e907c1..b090b2b26803 (1 commits) (flutter/engine#6193) e164e83 Reset the raster cache when the compositor context is created. (flutter/engine#6150) f02fc8c Dart SDK roll for 2018/09/06 (flutter/engine#6189) 58a1894 Update to latest clang (flutter/engine#6174) 9b297b3 Roll src/third_party/skia a9564d6dae1c..106d04e907c1 (7 commits) (flutter/engine#6190) e70d0e1 Always serialize fonts during skp capturing (flutter/engine#6160) bd7593b [fuchsia] Plumb root_surface_transformation in scene_update_context (flutter/engine#6187) 30c8da8 Pull $flutter_root:config into shell/engine/version:version (flutter/engine#6186) a146862 Roll src/third_party/skia 33d3d31a7e28..a9564d6dae1c (5 commits) (flutter/engine#6185) 058edef Fix LibTxt/minikin text shifiting when breaking into multiple runs (flutter/engine#6184) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary.
liyuqian
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 7, 2018
…21519) * Update goldens for flutter/engine#6184 * Roll engine to 9b297b3...
Hixie
pushed a commit
to Hixie/sky_engine
that referenced
this pull request
Sep 13, 2018
Hixie
added a commit
that referenced
this pull request
Sep 13, 2018
…riginally #6184) (#6242) This is for a test of the beta release patching process documented at https://github.com/flutter/flutter/wiki/Release-process This is an hopefully harmless arbitrary commit chosen from those that landed after the last beta's commit.
amirh
pushed a commit
to amirh/engine
that referenced
this pull request
Sep 21, 2018
amirh
pushed a commit
to amirh/engine
that referenced
this pull request
Sep 21, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#21442
Patched minikin to not round advances for no clear reason.
Added test to test for this in the future.